From: Carlos Llamas <cmllamas@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH v5 4/9] binder: remove struct binder_lru_page
Date: Tue, 26 Nov 2024 22:38:41 +0000 [thread overview]
Message-ID: <Z0ZN8QzIlK_NpOEg@google.com> (raw)
In-Reply-To: <Z0Ylr1cJ2AZ6rcXO@casper.infradead.org>
On Tue, Nov 26, 2024 at 07:46:55PM +0000, Matthew Wilcox wrote:
> On Tue, Nov 26, 2024 at 06:40:07PM +0000, Carlos Llamas wrote:
> > Remove the redundant struct binder_lru_page concept. Instead, let's use
> > available struct page->lru and page->private members directly to achieve
> > the same functionality. This reduces the maximum memory allocated for
> > alloc->pages from 32768 down to 8192 bytes (aarch64). Savings are per
> > binder instance.
> >
> > Note that Matthew pointed out that some of the page members used in this
> > patch (e.g. page->lru) are likely going to be removed in the near future
> > [1]. Binder will adopt an alternative solution when this happens.
>
> It's not just "near future". page->index is going away if not next
> merge window, then the merge window after. page->mapping is going to
> follow it, and page->lru after that. Please find another way now.
I see. I've found your patches removing page->index now. I'll go ahead
and rewire this to hang everything under page->private. Thanks for the
heads up Matthew.
--
Carlos Llamas
next prev parent reply other threads:[~2024-11-26 22:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 18:40 [PATCH v5 0/9] binder: faster page installations Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 1/9] Revert "binder: switch alloc->mutex to spinlock_t" Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 2/9] binder: concurrent page installation Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 3/9] binder: select correct nid for pages in LRU Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 4/9] binder: remove struct binder_lru_page Carlos Llamas
2024-11-26 19:46 ` Matthew Wilcox
2024-11-26 22:38 ` Carlos Llamas [this message]
2024-11-26 18:40 ` [PATCH v5 5/9] binder: replace alloc->vma with alloc->mapped Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 6/9] binder: rename alloc->buffer to vm_start Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 7/9] binder: use per-vma lock in page installation Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 8/9] binder: propagate vm_insert_page() errors Carlos Llamas
2024-11-26 18:40 ` [PATCH v5 9/9] binder: use per-vma lock in page reclaiming Carlos Llamas
2024-11-26 18:45 ` Suren Baghdasaryan
2024-11-26 18:46 ` Suren Baghdasaryan
2024-11-26 19:11 ` Carlos Llamas
2024-11-26 20:05 ` Suren Baghdasaryan
2024-11-26 23:32 ` Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0ZN8QzIlK_NpOEg@google.com \
--to=cmllamas@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.