From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
ilpo.jarvinen@linux.intel.com, danielwa@cisco.com
Subject: Re: [PATCH v3 2/4] p2sb: Introduce the global flag p2sb_hidden_by_bios
Date: Wed, 27 Nov 2024 13:47:21 +0200 [thread overview]
Message-ID: <Z0cGyelAEIVuhExV@smile.fi.intel.com> (raw)
In-Reply-To: <20241127060055.357498-3-shinichiro.kawasaki@wdc.com>
On Wed, Nov 27, 2024 at 03:00:53PM +0900, Shin'ichiro Kawasaki wrote:
> To prepare for the following fix, introduce the global flag
> p2sb_hidden_by_bios. Check if the BIOS hides the P2SB device and store
> the result in the flag. This allows to refer to the check result across
> functions.
Thinking about this I'm not sure we have no leftovers that are doing
the hide-unhide dance on their own, behind p2sb_bar()'s back. But
the idea is that all drivers that need this functionality in the kernel
have to work through p2sb_bar() entry point. If any problem is found
in the future with that, those will need to be fixed separately.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-27 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 6:00 [PATCH v3 0/4] p2sb: Fix unexpected P2SB device disappearance Shin'ichiro Kawasaki
2024-11-27 6:00 ` [PATCH v3 1/4] p2sb: Factor out p2sb_read_from_cache() Shin'ichiro Kawasaki
2024-11-27 6:00 ` [PATCH v3 2/4] p2sb: Introduce the global flag p2sb_hidden_by_bios Shin'ichiro Kawasaki
2024-11-27 11:47 ` Andy Shevchenko [this message]
2024-11-27 6:00 ` [PATCH v3 3/4] p2sb: Move P2SB hide and unhide code to p2sb_scan_and_cache() Shin'ichiro Kawasaki
2024-11-27 6:00 ` [PATCH v3 4/4] p2sb: Do not scan and remove the P2SB device when it is unhidden Shin'ichiro Kawasaki
2024-11-27 9:55 ` Hans de Goede
2024-11-28 0:26 ` Shinichiro Kawasaki
2024-11-28 12:59 ` Andy Shevchenko
2024-11-29 0:11 ` Shinichiro Kawasaki
2024-11-27 9:51 ` [PATCH v3 0/4] p2sb: Fix unexpected P2SB device disappearance Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0cGyelAEIVuhExV@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=danielwa@cisco.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.