Re: [PATCH] clk: renesas: r9a06g032: add restart handler

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Geert,

> > I got a RZ/N1D now. Before I start the real work, I need working
> > 'reboot' for fluent hacking :)
> 
> Yes, we all do ;-)

Well, previous N1D developers didn't, it seems...

> > +       error = register_restart_handler(&clocks->restart_nb);
> 
> You can simplify using devm_register_sys_off_handler(), cfr.
> drivers/power/reset/rmobile-reset.c.

Ok, will do, thanks for the pointer. One question, though...

> 
> > +       if (error)
> > +               dev_warn(dev, "couldn't register restart handler (%d)\n", error);

rmobile bails out on error. I still think a warning is enough. What is
your preference?

Thanks and happy hacking,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]