All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Łukasz Bartosik" <ukaszb@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Benson Leung <bleung@chromium.org>,
	Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
	Jameson Thies <jthies@google.com>,
	Pavan Holla <pholla@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev
Subject: Re: [PATCH v7 2/3] usb: typec: ucsi: Implement ChromeOS UCSI driver
Date: Thu, 28 Nov 2024 16:46:23 +0200	[thread overview]
Message-ID: <Z0iCP_2RM-c_yvU1@kuha.fi.intel.com> (raw)
In-Reply-To: <20241115155234.1587589-3-ukaszb@chromium.org>

Hi Łukasz,

This LGTM, but since you'll send one more version in any case..

> +/*
> + * Maximum time in miliseconds the cros_ec_ucsi driver
> + * will wait for a response to a command or and ack.
> + */
> +#define WRITE_TMO_MS		5000

s/miliseconds/milliseconds/

thanks,

-- 
heikki

  parent reply	other threads:[~2024-11-28 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15 15:52 [PATCH v7 0/3] usb: typec: Implement UCSI driver for ChromeOS Łukasz Bartosik
2024-11-15 15:52 ` [PATCH v7 1/3] platform/chrome: Update ChromeOS EC header for UCSI Łukasz Bartosik
2024-11-15 15:52 ` [PATCH v7 2/3] usb: typec: ucsi: Implement ChromeOS UCSI driver Łukasz Bartosik
2024-11-15 17:00   ` Dmitry Baryshkov
2024-11-18 10:09     ` Łukasz Bartosik
2024-11-18 10:21       ` Dmitry Baryshkov
2024-11-18 10:38         ` Łukasz Bartosik
2024-11-18 11:08           ` Dmitry Baryshkov
2024-11-18 11:18             ` Łukasz Bartosik
2024-11-21 23:05               ` Dmitry Baryshkov
2024-11-28 10:09                 ` Łukasz Bartosik
2024-11-28 14:46   ` Heikki Krogerus [this message]
2024-11-28 15:37     ` Łukasz Bartosik
2024-11-15 15:52 ` [PATCH v7 3/3] usb: typec: cros_ec_ucsi: Recover from write timeouts Łukasz Bartosik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0iCP_2RM-c_yvU1@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=abhishekpandit@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=jthies@google.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pholla@chromium.org \
    --cc=tzungbi@kernel.org \
    --cc=ukaszb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.