From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79E115C603 for ; Thu, 28 Nov 2024 14:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732805189; cv=none; b=VFm/flxwBMPVwVsoNxY5iig9DOgieP1v2o3LzbmNys2Qpf8DWvb0zWh5/70n+dHuQP57uvaX4ipKUaG7tAJdPYwDebDIX8Ew4pVz0GCeki0T8jp+obad1vOiNdRREevyiMhATSf7pmeP+gEbRHHca98Jsi30s4h80+c7hPvRsEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732805189; c=relaxed/simple; bh=dm+H6duiKZ1ALxKoVK3GAQQ7hN4dp0ZpY/FeLJZA0d0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SOisPM3Wmyd7N3UIPNAaY8I3vyf/fuXDyhVB796GXz4258Fc36i5vL6Y3aVM2Sn4z0QoSZScTi4rsV5kNscin+PbM+lghW7YhqjsVBbPAe4lokMbvpvtIcYnFOrMD9BY56YnlztEBCex3Fb/qXyQxIj3UsJDjBjv5zewg1YbTL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KxtkaT0v; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KxtkaT0v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732805188; x=1764341188; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=dm+H6duiKZ1ALxKoVK3GAQQ7hN4dp0ZpY/FeLJZA0d0=; b=KxtkaT0vD71eZbo2PjVxk/sBEmh2CPSEfR4SUCtRGKFnj/WLNs4Xxm1T w6WnWutVsa1Tz2ti4P3ZjFQE1yw5V1WXL98v3W7Z9YgJVJDK5tRU4XR5H bCVQQiu+azGxKwgkitiDzceEzHvkv9rg+QcUCOOsccmzatI1cFv6YXqtA JVnnKQecPtymv+AnWMtm/cIVNk+IcyExQhM7XKtKmBm7L3sSPfo/mS+1z 8EfgaViekKBgxwjbtnV9Sn12MLlThzRzsCsvB8A5M2Qz5l89TpQzs4y5G fJEmPWsQQd39GKvNj3Wf0K1OGUjeZorcSighDx44R/sVXFbJbt1swCKEd A==; X-CSE-ConnectionGUID: HCNKpT5iRaeVu+T3zB7mFQ== X-CSE-MsgGUID: 6Z+m4oaJTyCupL3XRj1wEw== X-IronPort-AV: E=McAfee;i="6700,10204,11270"; a="43529528" X-IronPort-AV: E=Sophos;i="6.12,192,1728975600"; d="scan'208";a="43529528" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2024 06:46:28 -0800 X-CSE-ConnectionGUID: nM5wbWuuSmaje/cHbTB9fg== X-CSE-MsgGUID: RMdJQHu9SRyn7//9a6cjow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,192,1728975600"; d="scan'208";a="97014315" Received: from kuha.fi.intel.com ([10.237.72.152]) by fmviesa004.fm.intel.com with SMTP; 28 Nov 2024 06:46:24 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 28 Nov 2024 16:46:24 +0200 Date: Thu, 28 Nov 2024 16:46:23 +0200 From: Heikki Krogerus To: =?utf-8?Q?=C5=81ukasz?= Bartosik Cc: Greg Kroah-Hartman , Benson Leung , Abhishek Pandit-Subedi , Jameson Thies , Pavan Holla , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Subject: Re: [PATCH v7 2/3] usb: typec: ucsi: Implement ChromeOS UCSI driver Message-ID: References: <20241115155234.1587589-1-ukaszb@chromium.org> <20241115155234.1587589-3-ukaszb@chromium.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241115155234.1587589-3-ukaszb@chromium.org> Hi Łukasz, This LGTM, but since you'll send one more version in any case.. > +/* > + * Maximum time in miliseconds the cros_ec_ucsi driver > + * will wait for a response to a command or and ack. > + */ > +#define WRITE_TMO_MS 5000 s/miliseconds/milliseconds/ thanks, -- heikki