From: Matthew Wilcox <willy@infradead.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: Dave Chinner <david@fromorbit.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] list_lru: expand list_lru_add() docs with info about sublists
Date: Thu, 28 Nov 2024 23:05:25 +0000 [thread overview]
Message-ID: <Z0j3Nfm_EXiGPObq@casper.infradead.org> (raw)
In-Reply-To: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com>
On Thu, Nov 28, 2024 at 12:12:11PM +0000, Alice Ryhl wrote:
> - * Return: true if the list was updated, false otherwise
> + * Return value: true if the item was added, false otherwise
This is an incorrect change. The section is always called 'Return', not
'Return value'; see Documentation/doc-guide/kernel-doc.rst. And I
think it was fine to say "list was updated" rather than "item was
added". They're basically synonyms.
> - * Return value: true if the list was updated, false otherwise
> + * Return value: true if the item was added, false otherwise
Ditto (and other similar changes)
next prev parent reply other threads:[~2024-11-28 23:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 12:12 [PATCH] list_lru: expand list_lru_add() docs with info about sublists Alice Ryhl
2024-11-28 21:12 ` Dave Chinner
2024-11-28 23:05 ` Matthew Wilcox [this message]
2024-11-29 8:58 ` Alice Ryhl
2024-11-29 14:36 ` Matthew Wilcox
2024-11-29 14:59 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0j3Nfm_EXiGPObq@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=cgroups@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.