From: Roman Gushchin <roman.gushchin@linux.dev>
To: John Sperbeck <jsperbeck@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcg: declare do_memsw_account inline
Date: Thu, 28 Nov 2024 22:48:23 +0000 [thread overview]
Message-ID: <Z0jzNx1UjIJuclIf@google.com> (raw)
In-Reply-To: <20241128203959.726527-1-jsperbeck@google.com>
On Thu, Nov 28, 2024 at 12:39:59PM -0800, John Sperbeck wrote:
> In commit 66d60c428b23 ("mm: memcg: move legacy memcg event code
> into memcontrol-v1.c"), the static do_memsw_account() function was
> moved from a .c file to a .h file. Unfortunately, the traditional
> inline keyword wasn't added. If a file (e.g., a unit test) includes
> the .h file, but doesn't refer to do_memsw_account(), it will get a
> warning like:
>
> mm/memcontrol-v1.h:41:13: warning: unused function 'do_memsw_account' [-Wunused-function]
> 41 | static bool do_memsw_account(void)
> | ^~~~~~~~~~~~~~~~
>
> Fixes: 66d60c428b23 ("mm: memcg: move legacy memcg event code into memcontrol-v1.c")
> Signed-off-by: John Sperbeck <jsperbeck@google.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks!
prev parent reply other threads:[~2024-11-28 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 20:39 [PATCH] mm: memcg: declare do_memsw_account inline John Sperbeck
2024-11-28 22:48 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0jzNx1UjIJuclIf@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jsperbeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.