All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Tianshu Qiu <tian.shu.qiu@intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bingbu Cao <bingbu.cao@intel.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 1/4] media: ov2740: Debug log chip ID
Date: Fri, 29 Nov 2024 14:22:37 +0100	[thread overview]
Message-ID: <Z0nAHYQWAp+hFkks@linux.intel.com> (raw)
In-Reply-To: <20241128152338.4583-2-hdegoede@redhat.com>

On Thu, Nov 28, 2024 at 04:23:35PM +0100, Hans de Goede wrote:
> Calling the identify function may get delayed till the first stream-on,
> add a dev_dbg() to it so that we know when it has run. This is useful
> to debug bring-up problems related to regulators / clks / GPIOs.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

> ---
>  drivers/media/i2c/ov2740.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
> index 387c529d9736..e7a611967b40 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -644,6 +644,8 @@ static int ov2740_identify_module(struct ov2740 *ov2740)
>  		return -ENXIO;
>  	}
>  
> +	dev_dbg(&client->dev, "chip id: %x\n", val);
> +
>  	ov2740->identified = true;
>  
>  	return 0;
> -- 
> 2.47.0
> 
> 

  parent reply	other threads:[~2024-11-29 13:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 15:23 [PATCH 0/4] media: ov2740: Various improvements Hans de Goede
2024-11-28 15:23 ` [PATCH 1/4] media: ov2740: Debug log chip ID Hans de Goede
2024-11-28 16:38   ` Ricardo Ribalda Delgado
2024-11-28 22:49     ` Ricardo Ribalda Delgado
2024-11-29 13:22   ` Stanislaw Gruszka [this message]
2024-11-28 15:23 ` [PATCH 2/4] media: ov2740: Add camera orientation and sensor rotation controls Hans de Goede
2024-11-28 16:44   ` Ricardo Ribalda Delgado
2024-12-15 22:47     ` Hans de Goede
2024-11-29 13:23   ` Stanislaw Gruszka
2024-11-28 15:23 ` [PATCH 3/4] media: ov2740: Add powerdown GPIO support Hans de Goede
2024-11-28 16:53   ` Ricardo Ribalda Delgado
2024-12-20 11:35     ` Hans de Goede
2024-12-20 12:30       ` Ricardo Ribalda Delgado
2024-11-29 13:23   ` Stanislaw Gruszka
2024-11-28 15:23 ` [PATCH 4/4] media: ov2740: Add regulator support Hans de Goede
2024-11-28 16:50   ` Ricardo Ribalda Delgado
2024-12-13  9:05     ` Sakari Ailus
2024-11-29 13:24   ` Stanislaw Gruszka
2024-12-13  9:04   ` Sakari Ailus
2024-12-20 11:40     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0nAHYQWAp+hFkks@linux.intel.com \
    --to=stanislaw.gruszka@linux.intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.