From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 4/5] tests/functional/test_vnc: Remove the test_no_vnc test
Date: Wed, 4 Dec 2024 10:42:08 +0000 [thread overview]
Message-ID: <Z1AyAESuqrZbLFq0@redhat.com> (raw)
In-Reply-To: <20241204071911.664057-5-thuth@redhat.com>
On Wed, Dec 04, 2024 at 08:19:10AM +0100, Thomas Huth wrote:
> This test matches exactly the first three lines of the following
> test_no_vnc_change_password test, so there is exactly zero additional
> test coverage in here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/test_vnc.py | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-12-04 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 7:19 [PATCH for-10.0 0/5] tests/functional: Convert tests with find_free_ports() Thomas Huth
2024-12-04 7:19 ` [PATCH 1/5] tests/functional: Convert the vnc test Thomas Huth
2024-12-04 7:19 ` [PATCH 2/5] tests/functional: Extract the find_free_ports() function into a helper file Thomas Huth
2024-12-04 10:41 ` Daniel P. Berrangé
2024-12-06 15:53 ` Thomas Huth
2024-12-04 10:46 ` Daniel P. Berrangé
2024-12-06 15:56 ` Thomas Huth
2024-12-04 7:19 ` [PATCH 3/5] tests/functional/test_vnc: Do not use a hard-coded VNC port Thomas Huth
2024-12-04 7:19 ` [PATCH 4/5] tests/functional/test_vnc: Remove the test_no_vnc test Thomas Huth
2024-12-04 10:42 ` Daniel P. Berrangé [this message]
2024-12-04 7:19 ` [PATCH 5/5] tests/functional: Convert the migration avocado test Thomas Huth
2024-12-04 8:27 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1AyAESuqrZbLFq0@redhat.com \
--to=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.