From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Lei Wei <quic_leiwei@quicinc.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_kkumarcs@quicinc.com,
quic_suruchia@quicinc.com, quic_pavir@quicinc.com,
quic_linchen@quicinc.com, quic_luoj@quicinc.com,
srinivas.kandagatla@linaro.org, bartosz.golaszewski@linaro.org,
vsmuthu@qti.qualcomm.com, john@phrozen.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/5] net: pcs: qcom-ipq9574: Add USXGMII interface mode support
Date: Wed, 4 Dec 2024 15:38:03 +0000 [thread overview]
Message-ID: <Z1B3W94-8qjn17Sj@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241204-ipq_pcs_rc1-v2-4-26155f5364a1@quicinc.com>
On Wed, Dec 04, 2024 at 10:43:56PM +0800, Lei Wei wrote:
> +static int ipq_pcs_link_up_config_usxgmii(struct ipq_pcs *qpcs, int speed)
> +{
...
> + /* USXGMII only support full duplex mode */
> + val |= XPCS_DUPLEX_FULL;
Again... this restriction needs to be implemented in .pcs_validate() by
knocking out the half-duplex link modes when using USXGMII mode.
.pcs_validate() needs to be implemented whenever the PCS has
restrictions beyond what is standard for the PHY interface mode.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-12-04 15:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 14:43 [PATCH net-next v2 0/5] Add PCS support for Qualcomm IPQ9574 SoC Lei Wei
2024-12-04 14:43 ` [PATCH net-next v2 1/5] dt-bindings: net: pcs: Add Ethernet PCS " Lei Wei
2024-12-05 9:47 ` Krzysztof Kozlowski
2024-12-04 14:43 ` [PATCH net-next v2 2/5] net: pcs: Add PCS driver " Lei Wei
2024-12-04 14:43 ` [PATCH net-next v2 3/5] net: pcs: qcom-ipq9574: Add PCS instantiation and phylink operations Lei Wei
2024-12-04 15:28 ` Russell King (Oracle)
2024-12-06 16:20 ` Lei Wei
2024-12-06 16:28 ` Russell King (Oracle)
2024-12-10 13:28 ` Lei Wei
2024-12-04 14:43 ` [PATCH net-next v2 4/5] net: pcs: qcom-ipq9574: Add USXGMII interface mode support Lei Wei
2024-12-04 15:38 ` Russell King (Oracle) [this message]
2024-12-06 16:20 ` Lei Wei
2024-12-06 16:31 ` Russell King (Oracle)
2024-12-10 13:25 ` Lei Wei
2024-12-04 14:43 ` [PATCH net-next v2 5/5] MAINTAINERS: Add maintainer for Qualcomm IPQ9574 PCS driver Lei Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1B3W94-8qjn17Sj@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vsmuthu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.