From: Vinod Koul <vkoul@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: Frank Li <frank.li@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"open list:FREESCALE eDMA DRIVER" <imx@lists.linux.dev>,
"open list:FREESCALE eDMA DRIVER" <dmaengine@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 2/2] dmaengine: fsl-edma: free irq correctly in remove path
Date: Wed, 4 Dec 2024 18:17:19 +0530 [thread overview]
Message-ID: <Z1BPV4fV8gOikmDF@vaman> (raw)
In-Reply-To: <DB9PR04MB8461407FB15C100903EFEFB988262@DB9PR04MB8461.eurprd04.prod.outlook.com>
On 17-11-24, 11:07, Peng Fan wrote:
> > Subject: Re: [PATCH V3 2/2] dmaengine: fsl-edma: free irq correctly in
> > remove path
> >
> > On Fri, Nov 15, 2024 at 06:56:29PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > To i.MX9, there is no valid fsl_edma->txirq/errirq, so add a check in
> > > fsl_edma_irq_exit to avoid issues. Otherwise there will be kernel
> > dump:
> >
> > Nik:
> >
> > Add fsl_edma->txirq/errirq check to avoid below warning because no
> > errirq at i.MX9 platform.
> >
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Thanks, since this is minor commit update. Not sure Vinok could help
> to update, or need me to update and send v4.
Not sure about Vinok :-) but I would prefer an updated patch
--
~Vinod
prev parent reply other threads:[~2024-12-04 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 10:56 [PATCH V3 1/2] dmaengine: fsl-edma: cleanup chan after dma_async_device_unregister Peng Fan (OSS)
2024-11-15 10:56 ` [PATCH V3 2/2] dmaengine: fsl-edma: free irq correctly in remove path Peng Fan (OSS)
2024-11-15 15:12 ` Frank Li
2024-11-17 11:07 ` Peng Fan
2024-12-04 12:47 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1BPV4fV8gOikmDF@vaman \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.