Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format

[Tommaso Merciai <tomm.merciai@gmail.com>]

On Wed, Dec 04, 2024 at 03:33:09PM +0200, Dmitry Baryshkov wrote:
> On Wed, Dec 04, 2024 at 02:11:28PM +0100, Tommaso Merciai wrote:
> > Hi Dmitry,
> > 
> > On Wed, Dec 04, 2024 at 01:53:44PM +0200, Dmitry Baryshkov wrote:
> > > On Wed, Dec 04, 2024 at 11:37:05AM +0100, Tommaso Merciai wrote:
> > > > Hi Liu Ying,
> > > > Thanks for your review.
> > > > 
> > > > On Wed, Dec 04, 2024 at 11:34:23AM +0800, Liu Ying wrote:
> > > > > On 12/04/2024, tomm.merciai@gmail.com wrote:
> > > > > > From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > > > > > 
> > > > > > Introduce it6263_is_input_bus_fmt_valid() and refactor the
> > > > > > it6263_bridge_atomic_get_input_bus_fmts() function to support VESA
> > > > > > format by selecting the LVDS input format based on the LVDS data mapping
> > > > > > and thereby support both JEIDA and VESA input formats.
> > > > > 
> > > > > ite,it6263.yaml says IT6263 supports vesa-24 and vesa-30, while
> > > > > this patch actually only adds vesa-24 support.  So, to be more
> > > > > specific, the patch subject and commit message should reflect
> > > > > this rather than claim "Support VESA input format".
> > > > 
> > > > Fully agree, thanks.
> > > > I will fix that in v2 specifying vesa-24 like you suggest.
> > > > 
> > > > > 
> > > > > > 
> > > > > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > > > > 
> > > > > Can you please send this patch with your Renesas email address
> > > > > instead of Gmail email address?
> > > > > Otherwise, add a Signed-off-by tag with your Gmail email address.
> > > > 
> > > > Thanks, for the point.
> > > > What about adding Acked-by: from my renesas email address?
> > > 
> > > Acked-by has a different meaning. I'd say that generally it's okay to
> > > have this light mismatch, see [1] or any of the emails that B4 generates
> > > for web-based submission.
> > > 
> > > [1] https://lore.kernel.org/dri-devel/20241121164858.457921-1-robdclark@gmail.com/
> > 
> > Thanks for sharing this example and for the clarification.
> > This is similar to my case :)
> > 
> > Then v1 procedure is correct?
> > I can use the same formatting (From: Sob:) for sending v2?
> 
> I think so

Oks, thanks for the feedback.

Regards,
Tommaso

> 
> > 
> > Thanks & Regards,
> > Tommaso
> > > 
> > > > 
> > > 
> > > -- 
> > > With best wishes
> > > Dmitry
> 
> -- 
> With best wishes
> Dmitry