From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Jai Luthra <jai.luthra@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 07/15] media: i2c: ds90ub960: Add support for I2C_RX_ID
Date: Thu, 5 Dec 2024 21:36:25 +0200 [thread overview]
Message-ID: <Z1IAucwlR031EW1y@smile.fi.intel.com> (raw)
In-Reply-To: <fa3405ce-a9f4-402d-b29c-d900858df974@ideasonboard.com>
On Thu, Dec 05, 2024 at 03:59:58PM +0200, Tomi Valkeinen wrote:
> On 05/12/2024 10:31, Andy Shevchenko wrote:
> > On Wed, Dec 04, 2024 at 01:05:21PM +0200, Tomi Valkeinen wrote:
...
> > > #define MHZ(v) ((u32)((v) * 1000000U))
> >
> > Missed HZ_PER_MHZ from previous patch?
>
> Yes, and no. I did leave the MHZ uses on purpose. I think the use of
> HZ_PER_MHZ was fine in the calculations, but when having table-ish use of
> MHZ, with hardcoded numbers, I found the MHZ() macro much nicer to read:
>
> case MHZ(1200):
>
> vs.
> case 1200 * HZ_PER_MHZ:
Had I talked about tables? :-)
I was only commented the calculations.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-05 19:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 11:05 [PATCH v3 00/15] media: i2c: ds90ub9xx: Misc fixes and improvements Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 01/15] media: i2c: ds90ub9x3: Fix extra fwnode_handle_put() Tomi Valkeinen
2024-12-09 9:09 ` Sakari Ailus
2024-12-09 9:46 ` Tomi Valkeinen
2024-12-09 9:53 ` Sakari Ailus
2024-12-04 11:05 ` [PATCH v3 02/15] media: i2c: ds90ub960: Fix UB9702 refclk register access Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 03/15] media: i2c: ds90ub960: Fix use of non-existing registers on UB9702 Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 04/15] media: i2c: ds90ub960: Fix logging SP & EQ status only for UB9702 Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 05/15] media: i2c: ds90ub960: Fix UB9702 VC map Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 06/15] media: i2c: ds90ub960: Use HZ_PER_MHZ Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 07/15] media: i2c: ds90ub960: Add support for I2C_RX_ID Tomi Valkeinen
2024-12-05 8:31 ` Andy Shevchenko
2024-12-05 12:00 ` Jai Luthra
2024-12-05 14:02 ` Tomi Valkeinen
2024-12-05 13:59 ` Tomi Valkeinen
2024-12-05 19:36 ` Andy Shevchenko [this message]
2024-12-06 7:24 ` Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 08/15] media: i2c: ds90ub960: Add RGB24, RAW8 and RAW10 formats Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 09/15] media: i2c: ds90ub953: Clear CRC errors in ub953_log_status() Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 10/15] media: i2c: ds90ub960: Drop unused indirect block define Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 11/15] media: i2c: ds90ub960: Reduce sleep in ub960_rxport_wait_locks() Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 12/15] media: i2c: ds90ub960: Handle errors in ub960_log_status_ub960_sp_eq() Tomi Valkeinen
2024-12-05 8:33 ` Andy Shevchenko
2024-12-04 11:05 ` [PATCH v3 13/15] media: i2c: ds90ub913: Add error handling to ub913_hw_init() Tomi Valkeinen
2024-12-04 11:05 ` [PATCH v3 14/15] media: i2c: ds90ub953: Add error handling for i2c reads/writes Tomi Valkeinen
2024-12-05 8:34 ` Andy Shevchenko
2024-12-04 11:05 ` [PATCH v3 15/15] media: i2c: ds90ub960: Fix shadowing of local variables Tomi Valkeinen
[not found] ` <67505692.920a0220.1e4a28.5c89@mx.google.com>
2024-12-04 13:44 ` [v3,00/15] media: i2c: ds90ub9xx: Misc fixes and improvements Tomi Valkeinen
2024-12-05 9:15 ` Sakari Ailus
2024-12-05 9:22 ` Ricardo Ribalda
2024-12-05 9:27 ` Tomi Valkeinen
2024-12-05 9:46 ` Ricardo Ribalda
2024-12-05 9:50 ` Sakari Ailus
2024-12-05 13:50 ` [PATCH v3 00/15] " Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1IAucwlR031EW1y@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jai.luthra@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.