All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org,
	"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Avihai Horon" <avihaih@nvidia.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH 2/2] migration/multifd: Allow to sync with sender threads only
Date: Thu, 5 Dec 2024 17:20:55 -0500	[thread overview]
Message-ID: <Z1InR552_UFBCdiZ@x1n> (raw)
In-Reply-To: <Z1IlX3Vp1hWmQjbT@x1n>

On Thu, Dec 05, 2024 at 05:12:47PM -0500, Peter Xu wrote:
> In case if I missed it, a runnable patch would work to clarify.

Ohhh no need now, I see what you meant.

But then you'll really need to comment p->sem, with something like:

-    /* sem where to wait for more work */
+    /* sem where to wait for more work.  If there's no any work, it means
+     * a local sync. */
     QemuSemaphore sem;

Do you like it?  I definitely don't.. because it's confusing why p->sem can
imply a sync request if we already have pending_sync.  IMHO it's cleaner
when we have pending_sync, use it for all kinds of syncs.

-- 
Peter Xu



      reply	other threads:[~2024-12-05 22:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 18:53 [PATCH 0/2] migration/multifd: Some VFIO preparations Peter Xu
2024-12-05 18:53 ` [PATCH 1/2] migration/multifd: Further remove the SYNC on complete Peter Xu
2024-12-05 19:55   ` Fabiano Rosas
2024-12-05 20:23     ` Peter Xu
2024-12-05 21:16       ` Fabiano Rosas
2024-12-05 22:00         ` Peter Xu
2024-12-05 18:53 ` [PATCH 2/2] migration/multifd: Allow to sync with sender threads only Peter Xu
2024-12-05 20:16   ` Fabiano Rosas
2024-12-05 20:35     ` Peter Xu
2024-12-05 21:50       ` Fabiano Rosas
2024-12-05 22:12         ` Peter Xu
2024-12-05 22:20           ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1InR552_UFBCdiZ@x1n \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=clg@redhat.com \
    --cc=farosas@suse.de \
    --cc=mail@maciej.szmigiero.name \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.