All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: anish kumar <yesanishhere@gmail.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
	<tiwai@suse.com>, <corbet@lwn.net>,
	<linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
	<linux-doc@vger.kernel.org>
Subject: Re: [PATCH V4] Docs/sound: Update codec-to-codec documentation
Date: Fri, 6 Dec 2024 10:34:56 +0000	[thread overview]
Message-ID: <Z1LTUDDJZyg1+OOz@opensource.cirrus.com> (raw)
In-Reply-To: <20241031211411.58726-1-yesanishhere@gmail.com>

On Thu, Oct 31, 2024 at 02:14:11PM -0700, anish kumar wrote:
> Updated documentation to provide more details
> for codec-to-codec connection especially around
> the scenarios and DAPM core details for C2C
> creation.
> 
> Signed-off-by: anish kumar <yesanishhere@gmail.com>
> ---
> +Boot-up logs will display message similar to:
> +
> +.. code-block:: text
> +
> +   ASoC: registered pcm #0 codec2codec(Playback Codec)
> +
> +To trigger this DAI link, a control interface is established by the

Probably better to describe this as a widget rather than a
control interface. This widget may have a control to switch the
params but really the key point is the widget here.

> +DAPM core during internal DAI creation. This interface links to
> +the ``snd_soc_dai_link_event`` function, which is invoked when a
> +path connects in the DAPM core. A mixer must be created to trigger
> +the connection, prompting the DAPM core to evaluate path

I am not 100% sure what we are going for here with "A mixer must
be created", I think we are saying that the DAPM graph must route
into the C2C link to power it up. I would be inclined to drop
this and just mention the callbacks that get called.

> +connections and call the ``snd_soc_dai_link_event`` callback with
> +SND_SOC_DAPM_*_PMU and SND_SOC_DAPM_*_PMD events.
> +
> +It is important to note that not all operations defined in
> +``snd_soc_dai_ops`` are invoked as C2C connections offer
> +limited control over DAI configuration. The operations typically
> +executed in C2C setups include startup, ``hw_params``, ``hw_free``,
> +digital mute, and shutdown from the ``snd_soc_dai_ops`` struct.
> +

But I think those are my only remaining comments.

Thanks,
Charles

      parent reply	other threads:[~2024-12-06 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 21:14 [PATCH V4] Docs/sound: Update codec-to-codec documentation anish kumar
2024-11-01  2:13 ` Bagas Sanjaya
2024-11-10 21:30   ` anish kumar
2024-11-12  0:54     ` Bagas Sanjaya
2024-11-12  1:17       ` anish kumar
2024-12-05 20:34         ` anish kumar
2024-12-06 10:34 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1LTUDDJZyg1+OOz@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=lgirdwood@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=yesanishhere@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.