Re: [PATCH v3 0/2] include: move include/qapi/qmp/ to include/qobject/

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Nov 18, 2024 at 04:12:33PM +0100, Markus Armbruster wrote:
> To repeat the 1st patch commit message...
> 
> The general expectation is that header files should follow the same
> file/path naming scheme as the corresponding source file. There are
> various historical exceptions to this practice in QEMU, with one of
> the most notable being the include/qapi/qmp/ directory. Most of the
> headers there correspond to source files in qobject/.
> 
> This patch corrects that inconsistency by creating include/qobject/.
> The only outlier is include/qapi/qmp/dispatch.h which gets renamed
> to include/qapi/qmp-registry.h.
> 
> Changed in v3:
> 
>  - Rebased, trivial semantic conflict with commit 34fdd734c5d resolved
> 
>  - Drop extra blank line [Zhao Liu]
> 
>  - Instead of doing both the move to qobject/ and the rename of
>    qmp/dispatch.h to qmp-registry.h together in one patch per
>    top-level directory, do them separately, but tree-wide.

You kept my S-o-B on the v3 re-arrangement which is fine, so not sure if
you're looking for additional R-b before merging in 10.0 dev cycle. If so,
you can add:

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|