From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E749A1F3D5B for ; Fri, 6 Dec 2024 17:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733505716; cv=none; b=N38Jl1cdGxrBR4Iw+Ag3mTN6jxg3+unEAxJP3UGZrR3hMmdVkoc4kjaeLePrV8xUyLZ1BBAS6B2WwSy2LIWW2sCv8gH1+pRMnQUX1bU5nYeXBUbVyLrx3RsIcbbtA3oUejdiZ+Y4AXSpt0EYUmPZCtl3KTd0WhdbRcbLji81K0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733505716; c=relaxed/simple; bh=5SWrXNXCkR/Tdwhr338AiMHE76pVRKR+l91Mb2XjOJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=deG/Qb/qNqpUBDtp2myV6S1SruhBlgjfX2k85+qiOmXB6qWIKII0HB/8us4EYPjcIsdQmyO0RdugEzE4wfg4mQ9/Tl3CL3tj6rmO+ffWmMO5DeuGGqV/67m8Yz4VVZDUI/R+jzdXPqXK/2ON7iI+v8iVW9vuHGFxaIx9Xz9wJgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=svJS3xIk; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="svJS3xIk" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2155157c31fso18474685ad.1 for ; Fri, 06 Dec 2024 09:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1733505714; x=1734110514; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+i+tasT2Gj7lYOeBeWZMOQQXNZXO0To2+VDLJbtR+G0=; b=svJS3xIkZu1I8f1icdjiiPnGXcUau9GdSmRZOqHtKXJ0FX/nPF9uxiUmxpQjvMxabu nUskllNtdlQJerJnSAumFinCiUHEVfjM0WlvSKPBEmI5IFqDWOcfqrpCZ1tfD4FOXUa5 c95eO6v+4QOBZDwnfZGJ6s0XXx8DTDrW+HQWhC06l2+pXJ7nT40QSuivQaWXMohaUcUJ IbxEAc7TC6KVcPXsePiqxTX/YO/uoOz3w3UnbXAn8PRkI/bkvGkOkxNRvCYCV6ZwcXb9 xf4nM0MjQ3Sk7kDEhtgZDnrlESdr0EdGBUFmzX3OqsEL2t2WStJHQ3DpDaB2OVT7FGiA yVlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733505714; x=1734110514; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+i+tasT2Gj7lYOeBeWZMOQQXNZXO0To2+VDLJbtR+G0=; b=gP9nF4a2YA5ixlDjNJ5MHkqjOH1OLoUoZb2B8wBMbFFUZtlR4+WialG19AvbwkyjQC 67nKRj9iRSlWCZgFQgzoBScQaiHpgVbN+QDp4HiMdDEh+p8eDdkZHCnteNXm71P4mQTy 1kuoIAXBztvCo7NaO0S6KxGCCH02cm2UjIngn5IWKWkCALBpBdtdbELPuVyShVrIwFoz itOgls8qEnFb3kd9ZQrVUb4SqiaeDutddsW6HpM03eUuIqnGrLzRpwS2yJIh/XUwr5bL cXWSjfm3tf4tFScfxT7D4Cf/aMBfzE2Gb7oXZm/O/zkNMOK8ULcuN7eWhOAcPTYDhgaf drlQ== X-Forwarded-Encrypted: i=1; AJvYcCWmSiuUK/4PRExn+X9jDWYjt8jCDLfiSF3SOEnwejhL9klvybZNGacOG+N2qPzssCGKQK/4dY8n6xaXXB4TtcI=@vger.kernel.org X-Gm-Message-State: AOJu0YyGMX+V4YBnYwCVtsRn2TxZSlBOUyUMTaSC4TAdsB/mfBCYCDRC gH0kPZe1yZnkTlb2iCI008KjQWrAmlKdJB5le18xZZkk06L610XcZlAICmOd1+Q= X-Gm-Gg: ASbGncvyNcYyU/IMI3QaM9pOH34YcD7cRJsKRkz1Nj4XXGK0izoiiedzVdD4kYV0PFJ pp+DsdD86qxdHa8ooAJh68q09Hp6BXX+V6hLj5KR6mmmzIQXXWtzEdc0a3fD7WLUkZrbZ9aIIdz TsApJMMYMkToUjlxN0mM797cvyEQ0AJwFQUPusFhUtbb6afjSm4iTlN3oMuOSVoyN9yiYY8xvR7 Flw9drex/vQk+/BfrspVh+5w7WKdjZP3XxcGoBhL33ztw== X-Google-Smtp-Source: AGHT+IGBrlMUCRA6EhqKpkEJniaz+WOJ8hm3M6cEs20NXgKFJ+7zC8Lu1pnHxeoDwgch7HO03IBy9A== X-Received: by 2002:a17:903:2309:b0:215:beb2:1039 with SMTP id d9443c01a7336-215f3c56b8cmr131489695ad.4.1733505714299; Fri, 06 Dec 2024 09:21:54 -0800 (PST) Received: from ghost ([2600:1010:b0ba:197a:c0e9:4a0e:e502:edf9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215f8f29beesm31109165ad.254.2024.12.06.09.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 09:21:53 -0800 (PST) Date: Fri, 6 Dec 2024 09:21:50 -0800 From: Charlie Jenkins To: Andrew Jones Cc: Shuah Khan , Paul Walmsley , Palmer Dabbelt , Samuel Holland , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt Subject: Re: [PATCH v4] riscv: selftests: Fix warnings pointer masking test Message-ID: References: <20241205-fix_warnings_pointer_masking_tests-v4-1-0c77eb725486@rivosinc.com> <20241206-6f0aafe057dc10df9a9e02a5@orel> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241206-6f0aafe057dc10df9a9e02a5@orel> On Fri, Dec 06, 2024 at 10:15:17AM +0100, Andrew Jones wrote: > On Thu, Dec 05, 2024 at 01:49:31PM -0800, Charlie Jenkins wrote: > > When compiling the pointer masking tests with -Wall this warning > > is present: > > > > pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: > > pointer_masking.c:203:9: warning: ignoring return value of ‘pwrite’ > > declared with attribute ‘warn_unused_result’ [-Wunused-result] > > 203 | pwrite(fd, &value, 1, 0); | > > ^~~~~~~~~~~~~~~~~~~~~~~~ pointer_masking.c:208:9: warning: > > ignoring return value of ‘pwrite’ declared with attribute > > ‘warn_unused_result’ [-Wunused-result] > > 208 | pwrite(fd, &value, 1, 0); > > > > I came across this on riscv64-linux-gnu-gcc (Ubuntu > > 11.4.0-1ubuntu1~22.04). > > > > Fix this by checking that the number of bytes written equal the expected > > number of bytes written. > > > > Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") > > Signed-off-by: Charlie Jenkins > > --- > > Changes in v4: > > - Skip sysctl_enabled test if first pwrite failed > > - Link to v3: https://lore.kernel.org/r/20241205-fix_warnings_pointer_masking_tests-v3-1-5c28b0f9640d@rivosinc.com > > > > Changes in v3: > > - Fix sysctl enabled test case (Drew/Alex) > > - Move pwrite err condition into goto (Drew) > > - Link to v2: https://lore.kernel.org/r/20241204-fix_warnings_pointer_masking_tests-v2-1-1bf0c5095f58@rivosinc.com > > > > Changes in v2: > > - I had ret != 2 for testing, I changed it to be ret != 1. > > - Link to v1: https://lore.kernel.org/r/20241204-fix_warnings_pointer_masking_tests-v1-1-ea1e9665ce7a@rivosinc.com > > --- > > tools/testing/selftests/riscv/abi/pointer_masking.c | 20 ++++++++++++++++++-- > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/riscv/abi/pointer_masking.c b/tools/testing/selftests/riscv/abi/pointer_masking.c > > index dee41b7ee3e3..759445d5f265 100644 > > --- a/tools/testing/selftests/riscv/abi/pointer_masking.c > > +++ b/tools/testing/selftests/riscv/abi/pointer_masking.c > > @@ -189,6 +189,8 @@ static void test_tagged_addr_abi_sysctl(void) > > { > > char value; > > int fd; > > + int ret; > > + char *err_pwrite_msg = "failed to write to /proc/sys/abi/tagged_addr_disabled\n"; > > > > ksft_print_msg("Testing tagged address ABI sysctl\n"); > > > > @@ -200,18 +202,32 @@ static void test_tagged_addr_abi_sysctl(void) > > } > > > > value = '1'; > > - pwrite(fd, &value, 1, 0); > > + ret = pwrite(fd, &value, 1, 0); > > + if (ret != 1) { > > + ksft_test_result_skip(err_pwrite_msg); > > It seems like we should have a better way to keep the count balanced than > to require a ksft_test_result_skip() call for each test on each error > path. Every time we add a test we'll have to go add skips everywhere else. It's only a problem if there are multiple tests in a single test function like there is here. Since the tests disable then reenable it makes sense to have them in one function, but does require us to do the skipping. > > > + goto err_pwrite; > > + } > > + > > ksft_test_result(set_tagged_addr_ctrl(min_pmlen, true) == -EINVAL, > > "sysctl disabled\n"); > > > > value = '0'; > > - pwrite(fd, &value, 1, 0); > > + ret = pwrite(fd, &value, 1, 0); > > + if (ret != 1) > > + goto err_pwrite; > > + > > ksft_test_result(set_tagged_addr_ctrl(min_pmlen, true) == 0, > > "sysctl enabled\n"); > > > > set_tagged_addr_ctrl(0, false); > > > > close(fd); > > + > > + return; > > + > > +err_pwrite: > > + close(fd); > > + ksft_test_result_fail(err_pwrite_msg); > > } > > I don't think the goto reduces much code or improves readability much. A > wrapper function should do better. I was thinking something like > > static bool pwrite_wrapper(int fd, void *buf, size_t count, const char *msg) > { > int ret = pwrite(fd, buf, count, 0); > if (ret != count) { > ksft_perror(msg); > return false; > } > return true; > } > > > value = '1'; > if (!pwrite_wrapper(fd, &value, 1, "write '1'")) > ksft_test_result_fail(...); > > value = '0'; > if (!pwrite_wrapper(fd, &value, 1, "write '0'")) > ksft_test_result_fail(...); > > Will do, thanks! - Charlie > > > > static void test_tagged_addr_abi_pmlen(int pmlen) > > > > --- > > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 > > change-id: 20241204-fix_warnings_pointer_masking_tests-3860e4f35429 > > -- > > - Charlie > > > > Thanks, > drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B394E77173 for ; Fri, 6 Dec 2024 17:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OKdFQpU+u7kPg/GJBqqqCXBBF4tmdwBq6tsqjSN+4YY=; b=1gkGf7HlfcUcah +feJCZpAAP7pkUsCOuAW9lGLPvZEbDDZUDsGNMpGPX4BDkn+wSbHz6nTSzxeQwOGL92CET5/m+hd5 uxzyy5lKkxTXRMaHGR5/aThtRrV6KH91yx5uSPn1ly4QCtN3mDAQwQ3fL3F/qZHwnquqlPZzgEh5v pN1GRZgvNzMOPSjy37s4yLyjShSOarrHy5VTrfNE6D3NvmNzB7sRoRfQackaM1e7Ud2d8EofH306U IiqjPjzW3UbKa1/cv6OZLD+hD316xufDRzIObGjDwEWTFkPmVEe27x3VZ1x38/aslP32qkjw7RQU0 gczBShphpM3LTk2qgg4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tJc1m-00000002Jam-0dDs; Fri, 06 Dec 2024 17:22:06 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tJc1b-00000002JWD-3Y0f for linux-riscv@lists.infradead.org; Fri, 06 Dec 2024 17:21:57 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-215513ea198so28170545ad.1 for ; Fri, 06 Dec 2024 09:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1733505714; x=1734110514; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+i+tasT2Gj7lYOeBeWZMOQQXNZXO0To2+VDLJbtR+G0=; b=QrTMqadvdIDK5VOy9dv8RIqZlBT3qluraYLvyR1Z9m/kPuSMCkwWfqoBHzaZ4jj1yw BKBPSmf+D1OfJerpibey2gNGhtzgU88JIYvtUr7lo1UXj0MuPSTsboytkjHL9VL2fYTe FNzCBia0cju/YG4CrrTE6oKIFjylVpiyHXAzVJYElSNcI2djhiHdlTPwAt6RIukN0Al4 9ywXAwlniY0jK0ZoUK534I1Tdv/+Dm662Z9oBOjyH3sq7z29Bi+sD9aSaI6FQR4xIh3A jzwpE9X5I9I0uua3HCtDzk/vMVulN++E7H5589BCm3TwV8bsVrvYHzzsmR76ww5vUPMw Q3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733505714; x=1734110514; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+i+tasT2Gj7lYOeBeWZMOQQXNZXO0To2+VDLJbtR+G0=; b=fpkBXxkKvtN8ImcqUqY9lleAxpNH2Jmu25uvKAI8nq+kJ3azKwvNsphGyM4pZFbY+f +mQzTEkOnvhSBfXy9fNh4X/lsJKnd7AN5ISdrBwojkP9cC4QXHdPZZF00JCUsVfdTAEn HTu/2OWvOwE9HR/bST2ETll6NOeSulCD/8klYEN5ACqK11f1juu9OcgX/oAEQwyvL3na JXDG4o/vFOLquSSBTPxrr0tIssvdGPscN1hvpPAWnaj8KY50m1KlFADuneaBcdnzNROX pgkgeJ4JbRKF3aMbhvN2jLwY/uM/CQktInO/STq6WfeHHfQF2QZ4YTbQkv5vQl/a11SF Q9/A== X-Forwarded-Encrypted: i=1; AJvYcCWqzWT4NM4Lah5qj1k8j46IilpP21L8uupEHgK0U7VbUU5KNpSGTm3OfaF4IWwhOfTXz3hbgZDaJWsu9Q==@lists.infradead.org X-Gm-Message-State: AOJu0YzSNkWtx6xtSzBZj0R3NdtBwI1oqjynIPfXtInqPf/pIGbzPWI9 as2LE6NOROAqon62FceOT3/6F29np69KcBBmRHkiAkIs5DOmtne6oXTWVDLMZgbCQJRzKql4+bO h4ak= X-Gm-Gg: ASbGncuIUkiCpaqoEg0b5MLc7JeQAui0unjrSNcniTIT/Weh6dZ/3ayBogIEk0wi6WU GcLqkP+0U0GkhGMm/qYsP3b+6iyTfmsrwG1Abk7gkqWnKSKD4sj9Si3sXl/ET2fnKsrBIgRgQp8 J9QBWkVqhav9a9aOaORv+xIE1TPBzni4N21Jaqmkqx61vZa8Ei6NzZWmIg0Tdu+RCjfaY5QE3eo xxUQK1O7Z0qeQGwSoayaLA5RSnzME/8fc+GMLonuqPwIA== X-Google-Smtp-Source: AGHT+IGBrlMUCRA6EhqKpkEJniaz+WOJ8hm3M6cEs20NXgKFJ+7zC8Lu1pnHxeoDwgch7HO03IBy9A== X-Received: by 2002:a17:903:2309:b0:215:beb2:1039 with SMTP id d9443c01a7336-215f3c56b8cmr131489695ad.4.1733505714299; Fri, 06 Dec 2024 09:21:54 -0800 (PST) Received: from ghost ([2600:1010:b0ba:197a:c0e9:4a0e:e502:edf9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215f8f29beesm31109165ad.254.2024.12.06.09.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 09:21:53 -0800 (PST) Date: Fri, 6 Dec 2024 09:21:50 -0800 From: Charlie Jenkins To: Andrew Jones Cc: Shuah Khan , Paul Walmsley , Palmer Dabbelt , Samuel Holland , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt Subject: Re: [PATCH v4] riscv: selftests: Fix warnings pointer masking test Message-ID: References: <20241205-fix_warnings_pointer_masking_tests-v4-1-0c77eb725486@rivosinc.com> <20241206-6f0aafe057dc10df9a9e02a5@orel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241206-6f0aafe057dc10df9a9e02a5@orel> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241206_092155_886241_0348F51E X-CRM114-Status: GOOD ( 30.24 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBEZWMgMDYsIDIwMjQgYXQgMTA6MTU6MTdBTSArMDEwMCwgQW5kcmV3IEpvbmVzIHdy b3RlOgo+IE9uIFRodSwgRGVjIDA1LCAyMDI0IGF0IDAxOjQ5OjMxUE0gLTA4MDAsIENoYXJsaWUg SmVua2lucyB3cm90ZToKPiA+IFdoZW4gY29tcGlsaW5nIHRoZSBwb2ludGVyIG1hc2tpbmcgdGVz dHMgd2l0aCAtV2FsbCB0aGlzIHdhcm5pbmcKPiA+IGlzIHByZXNlbnQ6Cj4gPiAKPiA+IHBvaW50 ZXJfbWFza2luZy5jOiBJbiBmdW5jdGlvbiDigJh0ZXN0X3RhZ2dlZF9hZGRyX2FiaV9zeXNjdGzi gJk6Cj4gPiBwb2ludGVyX21hc2tpbmcuYzoyMDM6OTogd2FybmluZzogaWdub3JpbmcgcmV0dXJu IHZhbHVlIG9mIOKAmHB3cml0ZeKAmQo+ID4gZGVjbGFyZWQgd2l0aCBhdHRyaWJ1dGUg4oCYd2Fy bl91bnVzZWRfcmVzdWx04oCZIFstV3VudXNlZC1yZXN1bHRdCj4gPiAgIDIwMyB8ICAgICAgICAg cHdyaXRlKGZkLCAmdmFsdWUsIDEsIDApOyB8Cj4gPiAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn4gcG9pbnRlcl9tYXNraW5nLmM6MjA4Ojk6IHdhcm5pbmc6Cj4gPiBpZ25vcmluZyByZXR1 cm4gdmFsdWUgb2Yg4oCYcHdyaXRl4oCZIGRlY2xhcmVkIHdpdGggYXR0cmlidXRlCj4gPiDigJh3 YXJuX3VudXNlZF9yZXN1bHTigJkgWy1XdW51c2VkLXJlc3VsdF0KPiA+ICAgMjA4IHwgICAgICAg ICBwd3JpdGUoZmQsICZ2YWx1ZSwgMSwgMCk7Cj4gPiAKPiA+IEkgY2FtZSBhY3Jvc3MgdGhpcyBv biByaXNjdjY0LWxpbnV4LWdudS1nY2MgKFVidW50dQo+ID4gMTEuNC4wLTF1YnVudHUxfjIyLjA0 KS4KPiA+IAo+ID4gRml4IHRoaXMgYnkgY2hlY2tpbmcgdGhhdCB0aGUgbnVtYmVyIG9mIGJ5dGVz IHdyaXR0ZW4gZXF1YWwgdGhlIGV4cGVjdGVkCj4gPiBudW1iZXIgb2YgYnl0ZXMgd3JpdHRlbi4K PiA+IAo+ID4gRml4ZXM6IDc0NzBiNWFmZDE1MCAoInJpc2N2OiBzZWxmdGVzdHM6IEFkZCBhIHBv aW50ZXIgbWFza2luZyB0ZXN0IikKPiA+IFNpZ25lZC1vZmYtYnk6IENoYXJsaWUgSmVua2lucyA8 Y2hhcmxpZUByaXZvc2luYy5jb20+Cj4gPiAtLS0KPiA+IENoYW5nZXMgaW4gdjQ6Cj4gPiAtIFNr aXAgc3lzY3RsX2VuYWJsZWQgdGVzdCBpZiBmaXJzdCBwd3JpdGUgZmFpbGVkCj4gPiAtIExpbmsg dG8gdjM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyNDEyMDUtZml4X3dhcm5pbmdzX3Bv aW50ZXJfbWFza2luZ190ZXN0cy12My0xLTVjMjhiMGY5NjQwZEByaXZvc2luYy5jb20KPiA+IAo+ ID4gQ2hhbmdlcyBpbiB2MzoKPiA+IC0gRml4IHN5c2N0bCBlbmFibGVkIHRlc3QgY2FzZSAoRHJl dy9BbGV4KQo+ID4gLSBNb3ZlIHB3cml0ZSBlcnIgY29uZGl0aW9uIGludG8gZ290byAoRHJldykK PiA+IC0gTGluayB0byB2MjogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8yMDI0MTIwNC1maXhf d2FybmluZ3NfcG9pbnRlcl9tYXNraW5nX3Rlc3RzLXYyLTEtMWJmMGM1MDk1ZjU4QHJpdm9zaW5j LmNvbQo+ID4gCj4gPiBDaGFuZ2VzIGluIHYyOgo+ID4gLSBJIGhhZCByZXQgIT0gMiBmb3IgdGVz dGluZywgSSBjaGFuZ2VkIGl0IHRvIGJlIHJldCAhPSAxLgo+ID4gLSBMaW5rIHRvIHYxOiBodHRw czovL2xvcmUua2VybmVsLm9yZy9yLzIwMjQxMjA0LWZpeF93YXJuaW5nc19wb2ludGVyX21hc2tp bmdfdGVzdHMtdjEtMS1lYTFlOTY2NWNlN2FAcml2b3NpbmMuY29tCj4gPiAtLS0KPiA+ICB0b29s cy90ZXN0aW5nL3NlbGZ0ZXN0cy9yaXNjdi9hYmkvcG9pbnRlcl9tYXNraW5nLmMgfCAyMCArKysr KysrKysrKysrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvdG9vbHMvdGVzdGluZy9zZWxmdGVz dHMvcmlzY3YvYWJpL3BvaW50ZXJfbWFza2luZy5jIGIvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMv cmlzY3YvYWJpL3BvaW50ZXJfbWFza2luZy5jCj4gPiBpbmRleCBkZWU0MWI3ZWUzZTMuLjc1OTQ0 NWQ1ZjI2NSAxMDA2NDQKPiA+IC0tLSBhL3Rvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3Jpc2N2L2Fi aS9wb2ludGVyX21hc2tpbmcuYwo+ID4gKysrIGIvdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvcmlz Y3YvYWJpL3BvaW50ZXJfbWFza2luZy5jCj4gPiBAQCAtMTg5LDYgKzE4OSw4IEBAIHN0YXRpYyB2 b2lkIHRlc3RfdGFnZ2VkX2FkZHJfYWJpX3N5c2N0bCh2b2lkKQo+ID4gIHsKPiA+ICAJY2hhciB2 YWx1ZTsKPiA+ICAJaW50IGZkOwo+ID4gKwlpbnQgcmV0Owo+ID4gKwljaGFyICplcnJfcHdyaXRl X21zZyA9ICJmYWlsZWQgdG8gd3JpdGUgdG8gL3Byb2Mvc3lzL2FiaS90YWdnZWRfYWRkcl9kaXNh YmxlZFxuIjsKPiA+ICAKPiA+ICAJa3NmdF9wcmludF9tc2coIlRlc3RpbmcgdGFnZ2VkIGFkZHJl c3MgQUJJIHN5c2N0bFxuIik7Cj4gPiAgCj4gPiBAQCAtMjAwLDE4ICsyMDIsMzIgQEAgc3RhdGlj IHZvaWQgdGVzdF90YWdnZWRfYWRkcl9hYmlfc3lzY3RsKHZvaWQpCj4gPiAgCX0KPiA+ICAKPiA+ ICAJdmFsdWUgPSAnMSc7Cj4gPiAtCXB3cml0ZShmZCwgJnZhbHVlLCAxLCAwKTsKPiA+ICsJcmV0 ID0gcHdyaXRlKGZkLCAmdmFsdWUsIDEsIDApOwo+ID4gKwlpZiAocmV0ICE9IDEpIHsKPiA+ICsJ CWtzZnRfdGVzdF9yZXN1bHRfc2tpcChlcnJfcHdyaXRlX21zZyk7Cj4gCj4gSXQgc2VlbXMgbGlr ZSB3ZSBzaG91bGQgaGF2ZSBhIGJldHRlciB3YXkgdG8ga2VlcCB0aGUgY291bnQgYmFsYW5jZWQg dGhhbgo+IHRvIHJlcXVpcmUgYSBrc2Z0X3Rlc3RfcmVzdWx0X3NraXAoKSBjYWxsIGZvciBlYWNo IHRlc3Qgb24gZWFjaCBlcnJvcgo+IHBhdGguIEV2ZXJ5IHRpbWUgd2UgYWRkIGEgdGVzdCB3ZSds bCBoYXZlIHRvIGdvIGFkZCBza2lwcyBldmVyeXdoZXJlIGVsc2UuCgpJdCdzIG9ubHkgYSBwcm9i bGVtIGlmIHRoZXJlIGFyZSBtdWx0aXBsZSB0ZXN0cyBpbiBhIHNpbmdsZSB0ZXN0CmZ1bmN0aW9u IGxpa2UgdGhlcmUgaXMgaGVyZS4gU2luY2UgdGhlIHRlc3RzIGRpc2FibGUgdGhlbiByZWVuYWJs ZSBpdAptYWtlcyBzZW5zZSB0byBoYXZlIHRoZW0gaW4gb25lIGZ1bmN0aW9uLCBidXQgZG9lcyBy ZXF1aXJlIHVzIHRvIGRvIHRoZQpza2lwcGluZy4KCj4gCj4gPiArCQlnb3RvIGVycl9wd3JpdGU7 Cj4gPiArCX0KPiA+ICsKPiA+ICAJa3NmdF90ZXN0X3Jlc3VsdChzZXRfdGFnZ2VkX2FkZHJfY3Ry bChtaW5fcG1sZW4sIHRydWUpID09IC1FSU5WQUwsCj4gPiAgCQkJICJzeXNjdGwgZGlzYWJsZWRc biIpOwo+ID4gIAo+ID4gIAl2YWx1ZSA9ICcwJzsKPiA+IC0JcHdyaXRlKGZkLCAmdmFsdWUsIDEs IDApOwo+ID4gKwlyZXQgPSBwd3JpdGUoZmQsICZ2YWx1ZSwgMSwgMCk7Cj4gPiArCWlmIChyZXQg IT0gMSkKPiA+ICsJCWdvdG8gZXJyX3B3cml0ZTsKPiA+ICsKPiA+ICAJa3NmdF90ZXN0X3Jlc3Vs dChzZXRfdGFnZ2VkX2FkZHJfY3RybChtaW5fcG1sZW4sIHRydWUpID09IDAsCj4gPiAgCQkJICJz eXNjdGwgZW5hYmxlZFxuIik7Cj4gPiAgCj4gPiAgCXNldF90YWdnZWRfYWRkcl9jdHJsKDAsIGZh bHNlKTsKPiA+ICAKPiA+ICAJY2xvc2UoZmQpOwo+ID4gKwo+ID4gKwlyZXR1cm47Cj4gPiArCj4g PiArZXJyX3B3cml0ZToKPiA+ICsJY2xvc2UoZmQpOwo+ID4gKwlrc2Z0X3Rlc3RfcmVzdWx0X2Zh aWwoZXJyX3B3cml0ZV9tc2cpOwo+ID4gIH0KPiAKPiBJIGRvbid0IHRoaW5rIHRoZSBnb3RvIHJl ZHVjZXMgbXVjaCBjb2RlIG9yIGltcHJvdmVzIHJlYWRhYmlsaXR5IG11Y2guIEEKPiB3cmFwcGVy IGZ1bmN0aW9uIHNob3VsZCBkbyBiZXR0ZXIuIEkgd2FzIHRoaW5raW5nIHNvbWV0aGluZyBsaWtl Cj4gCj4gIHN0YXRpYyBib29sIHB3cml0ZV93cmFwcGVyKGludCBmZCwgdm9pZCAqYnVmLCBzaXpl X3QgY291bnQsIGNvbnN0IGNoYXIgKm1zZykKPiAgewo+ICAgIGludCByZXQgPSBwd3JpdGUoZmQs IGJ1ZiwgY291bnQsIDApOwo+ICAgIGlmIChyZXQgIT0gY291bnQpIHsKPiAgICAgICBrc2Z0X3Bl cnJvcihtc2cpOwo+ICAgICAgIHJldHVybiBmYWxzZTsKPiAgICB9Cj4gICAgcmV0dXJuIHRydWU7 Cj4gIH0KPiAKPiAKPiAgdmFsdWUgPSAnMSc7Cj4gIGlmICghcHdyaXRlX3dyYXBwZXIoZmQsICZ2 YWx1ZSwgMSwgIndyaXRlICcxJyIpKQo+ICAgICBrc2Z0X3Rlc3RfcmVzdWx0X2ZhaWwoLi4uKTsK PiAKPiAgdmFsdWUgPSAnMCc7Cj4gIGlmICghcHdyaXRlX3dyYXBwZXIoZmQsICZ2YWx1ZSwgMSwg IndyaXRlICcwJyIpKQo+ICAgICBrc2Z0X3Rlc3RfcmVzdWx0X2ZhaWwoLi4uKTsKPiAKPiAKCldp bGwgZG8sIHRoYW5rcyEKCi0gQ2hhcmxpZQoKPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCB0ZXN0X3Rh Z2dlZF9hZGRyX2FiaV9wbWxlbihpbnQgcG1sZW4pCj4gPiAKPiA+IC0tLQo+ID4gYmFzZS1jb21t aXQ6IDQwMzg0Yzg0MGVhMTk0NGQ3YzVhMzkyZTg5NzVlZDA4OGVjZjBiMzcKPiA+IGNoYW5nZS1p ZDogMjAyNDEyMDQtZml4X3dhcm5pbmdzX3BvaW50ZXJfbWFza2luZ190ZXN0cy0zODYwZTRmMzU0 MjkKPiA+IC0tIAo+ID4gLSBDaGFybGllCj4gPiAKPiAKPiBUaGFua3MsCj4gZHJldwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=