From: Matthew Wilcox <willy@infradead.org>
To: Junjie Fu <fujunjie1@qq.com>
Cc: akpm@linux-foundation.org, gourry@gourry.net,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com
Subject: Re: [PATCH] mm/mempolicy.c: include pagemap.h directly
Date: Sat, 7 Dec 2024 17:14:14 +0000 [thread overview]
Message-ID: <Z1SCZlMcjBCzHOxf@casper.infradead.org> (raw)
In-Reply-To: <tencent_38F9530F8D11EC9B038B77AE97E73145DA07@qq.com>
On Sat, Dec 07, 2024 at 04:14:30PM +0800, Junjie Fu wrote:
> @@ -113,7 +113,7 @@
> #include <asm/tlbflush.h>
> #include <asm/tlb.h>
> #include <linux/uaccess.h>
> -
> +#include <linux/pagemap.h>
> #include "internal.h"
This is in the wrong place. The linux/ includes go before the asm/
includes. I like to stick to alphabetical order within that divide,
but other people have other preferences.
next prev parent reply other threads:[~2024-12-07 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 15:53 [PATCH] mempolicy.h: Remove unnecessary header file inclusions Junjie Fu
2024-12-07 6:00 ` Andrew Morton
2024-12-07 8:14 ` [PATCH] mm/mempolicy.c: include pagemap.h directly Junjie Fu
2024-12-07 17:14 ` Matthew Wilcox [this message]
2024-12-07 18:22 ` [PATCH] mm/mempolicy.c: include pagemap.h directly in right place Junjie Fu
2024-12-07 19:53 ` [PATCH] mempolicy.h: Remove unnecessary header file inclusions SeongJae Park
2024-12-07 21:55 ` Matthew Wilcox
2024-12-08 13:50 ` Junjie Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1SCZlMcjBCzHOxf@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fujunjie1@qq.com \
--cc=gourry@gourry.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.