Re: [PATCH 3/3] cmd: ufetch: Show CPU architecture under "CPU"

["J. Neuschäfer" <j.ne@posteo.net>]

On Mon, Dec 09, 2024 at 04:09:30PM +0100, Caleb Connolly wrote:
> Thanks for the patch!
> 
> On 05/12/2024 19:35, J. Neuschäfer via B4 Relay wrote:
> > From: "J. Neuschäfer" <j.ne@posteo.net>
> > 
> > When looking at ufetch output it isn't immediately obvious which CPU
> > architecture the presented board has. This patch therefore adds the CPU
> > architecture string (for example "powerpc") to the "CPU:" line.
> 
> It would be nice to have the proper fancy name, but this is an
> improvement nonetheless.

True

> > 
> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> > ---
[...]
> > -			printf("CPU:" RESET " %d (1 in use)\n", n_cpus);
> > +			printf("CPU: " RESET CONFIG_SYS_ARCH ", %d (1 in use)\n", n_cpus);
> 
> This will read like
> 
> CPU: arm 4 (1 in use)
> 
> which is a bit hard to parse at a glance. How about
> 
> CPU: arm [4 cores]
> 
> or some other separator between SYS_ARCH and the core count?

Ah yup, good idea. I also struggled with reading this line as it was;
"4 cores" or similar makes it clear what the number means.


-- jn