All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Arun R Murthy <arun.r.murthy@intel.com>,
	intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCHv10 00/10] Display Global Histogram
Date: Mon, 9 Dec 2024 19:43:55 +0200	[thread overview]
Message-ID: <Z1csWzRHDzU0pds9@black.fi.intel.com> (raw)
In-Reply-To: <20241209165756.GQ3224633@mdroper-desk1.amr.corp.intel.com>

On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote:
> On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote:
> > Display histogram is a hardware functionality where a statistics for 'x'
> > number of frames is generated to form a histogram data. This is notified
> > to the user via histogram event. Compositor will then upon sensing the
> > histogram event will read the histogram data from KMD via crtc property.
> > A library can be developed to take this generated histogram as an
> > input and apply some algorithm to generate an Image EnhancemenT(IET).
> > This is further fed back to the KMD via crtc property. KMD will use this
> > IET as a multiplicand factor to multiply with the incoming pixels at the
> > end of the pipe which is then pushed onto the display.
> > 
> > One such library Global Histogram Enhancement(GHE) will take the histogram
> > as input and applied the algorithm to enhance the density and then
> > return the enhanced factor. This library can be located @
> > https://github.com/intel/ghe
> > 
> > The corresponding mutter changes to enable/disable histogram, read the
> > histogram data, communicate with the library and write the enhanced data
> > back to the KMD is also pushed for review at https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3873
> > and https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3873/diffs?commit_id=270808ca7c8be48513553d95b4a47541f5d40206
> > The IGT changes for validating the histogram event and reading the
> > histogram is also pushed for review at https://patchwork.freedesktop.org/series/135789/
> 
> I think other people have already asked this on previous postings of
> these patches, but please don't try to manually hack the version numbers
> within a series.  What you just posted has "PATCHv10" on the cover
> letter, "PATCHv2" on one patch, "PATCHv3" on three patches, and the rest
> are unversioned "PATCH."  The general expectation these days is that
> versioning in the subject applies to the series as a whole, not the
> individual patches, so this causes a lot of confusion.  Posting like you
> did here also wrecks havoc on a lot of the tools people use to manage
> and compare series like the "b4" tool.
> 
> When generating and sending a new series, you should just do something
> like "git format-patch -v10 ..." so that the proper "v10" numbering is
> automatically applied to all the patches and we don't wind up with this
> strange jumble.

Isn't that the starting point?

https://kernelnewbies.org/FirstKernelPatch -> "Versioning patchsets"

Raag

  reply	other threads:[~2024-12-09 17:44 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 16:24 [PATCHv10 00/10] Display Global Histogram Arun R Murthy
2024-12-09 16:24 ` [PATCHv3 01/10] drm/crtc: Add histogram properties Arun R Murthy
2024-12-10  0:26   ` Dmitry Baryshkov
2024-12-10  8:42     ` Murthy, Arun R
2024-12-10 12:27       ` Dmitry Baryshkov
2024-12-10 17:52         ` Murthy, Arun R
2024-12-13 10:51           ` Dmitry Baryshkov
2025-01-06  6:05             ` Murthy, Arun R
2024-12-10  0:58   ` Dmitry Baryshkov
2024-12-09 16:24 ` [PATCHv3 02/10] drm/crtc: Expose API to create drm crtc property for histogram Arun R Murthy
2024-12-09 16:24 ` [PATCH 03/10] drm/i915/histogram: Define registers " Arun R Murthy
2024-12-09 16:24 ` [PATCH 04/10] drm/i915/histogram: Add support " Arun R Murthy
2024-12-11  0:08   ` kernel test robot
2024-12-12 10:18   ` kernel test robot
2024-12-09 16:24 ` [PATCH 05/10] drm/xe: Add histogram support to Xe builds Arun R Murthy
2024-12-10  3:34   ` kernel test robot
2024-12-09 16:25 ` [PATCH 06/10] drm/i915/histogram: histogram interrupt handling Arun R Murthy
2024-12-09 16:25 ` [PATCHv3 07/10] drm/i915/display: Handle drm-crtc histogram property updates Arun R Murthy
2024-12-10 12:48   ` Kandpal, Suraj
2024-12-09 16:25 ` [PATCH 08/10] drm/i915/histogram: histogram delay counter doesnt reset Arun R Murthy
2024-12-09 16:25 ` [PATCH 09/10] drm/i915/histogram: Histogram changes for Display 20+ Arun R Murthy
2024-12-09 16:25 ` [PATCHv2 10/10] drm/i915/histogram: Enable pipe dithering Arun R Murthy
2024-12-10 12:45   ` Kandpal, Suraj
2024-12-09 16:46 ` ✓ CI.Patch_applied: success for Display Global Histogram (rev6) Patchwork
2024-12-09 16:47 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-09 16:48 ` ✓ CI.KUnit: success " Patchwork
2024-12-09 16:57 ` [PATCHv10 00/10] Display Global Histogram Matt Roper
2024-12-09 17:43   ` Raag Jadav [this message]
2024-12-09 18:18     ` Matt Roper
2024-12-09 18:57       ` Raag Jadav
2024-12-09 20:17       ` Raag Jadav
2024-12-10  8:43   ` Murthy, Arun R
2024-12-09 17:06 ` ✓ CI.Build: success for Display Global Histogram (rev6) Patchwork
2024-12-09 17:08 ` ✗ CI.Hooks: failure " Patchwork
2024-12-09 17:10 ` ✗ CI.checksparse: warning " Patchwork
2024-12-09 19:01 ` ✗ Fi.CI.CHECKPATCH: warning for Display Global Histogram (rev10) Patchwork
2024-12-09 19:01 ` ✗ Fi.CI.SPARSE: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1csWzRHDzU0pds9@black.fi.intel.com \
    --to=raag.jadav@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.