From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/6] tests/qtest/migration: Initialize buffer in probe_o_direct_support
Date: Mon, 9 Dec 2024 16:14:38 -0500 [thread overview]
Message-ID: <Z1ddvtuy8-3LgMKv@x1n> (raw)
In-Reply-To: <20241209204427.17763-3-farosas@suse.de>
On Mon, Dec 09, 2024 at 05:44:23PM -0300, Fabiano Rosas wrote:
> Valgrind complains about the probe_o_direct_support() function reading
> from an uninitialized buffer. For probing O_DIRECT support we don't
> actually need to write to the file, just make sure the pwrite call
> doesn't reject the write. Still, write zeroes to the buffer to
> suppress the warning.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2024-12-09 21:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 20:44 [PATCH 0/6] qtest: Fix some memory issues Fabiano Rosas
2024-12-09 20:44 ` [PATCH 1/6] tests/qtest/migration: Do proper cleanup in the dirty_limit test Fabiano Rosas
2024-12-09 21:11 ` Peter Xu
2024-12-09 20:44 ` [PATCH 2/6] tests/qtest/migration: Initialize buffer in probe_o_direct_support Fabiano Rosas
2024-12-09 21:02 ` Philippe Mathieu-Daudé
2024-12-09 21:14 ` Peter Xu [this message]
2024-12-09 20:44 ` [PATCH 3/6] tests/qtest/bios-tables-test: Free tables at dump_aml_files Fabiano Rosas
2024-12-09 21:04 ` Philippe Mathieu-Daudé
2024-12-09 20:44 ` [PATCH 4/6] tests/qtest/virtio-iommu-test: Don't pass uninitialized data into qtest_memwrite Fabiano Rosas
2024-12-09 21:06 ` Philippe Mathieu-Daudé
2024-12-09 20:44 ` [PATCH 5/6] tests/qtest/qos-test: Plug a couple of leaks Fabiano Rosas
2024-12-09 20:44 ` [PATCH 6/6] tests/qtest/test-x86-cpuid-compat: Free allocated memory Fabiano Rosas
2024-12-17 18:13 ` [PATCH 0/6] qtest: Fix some memory issues Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1ddvtuy8-3LgMKv@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.