All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: u-boot@lists.denx.de, Alexander Dahl <ada@thorsis.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	Igor Prusov <ivprusov@salutedevices.com>,
	Sean Anderson <seanga2@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] mtd: nand: raw: atmel: remove unnecessary return value
Date: Tue, 10 Dec 2024 08:08:47 +0100	[thread overview]
Message-ID: <Z1fo_xrE8jLve6pK@gmail.com> (raw)
In-Reply-To: <CAOf5uwkhkCuW-st6ZnEVcQv6gDuRXSog_AQh_KQCUECFuyZ3sw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Hello Michael,

On Fri, Aug 30, 2024 at 09:05:27AM +0200, Michael Nazzareno Trimarchi wrote:
> Hi Marcus
> 
> On Fri, Aug 30, 2024 at 8:59 AM Marcus Folkesson
> <marcus.folkesson@gmail.com> wrote:
> >
> > On Fri, Aug 09, 2024 at 02:15:43PM +0200, Marcus Folkesson wrote:
> > > The condition 'ret' is always true as it is never set to other than
> > > -EIO.
> > >
> > > Remove 'ret' and the condition for copy.
> > >
> > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > > ---
> >
> > Any more thoughts on this?
> 
> Reviewed-by: Michael Trimarchi <micheal@amarulasolutions.com>
> 
> It will be included in the next pull request.

Not sure it got included?

> 
> Michael
> 

Thanks,
Marcus Folkesson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-12-10 12:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 12:15 [PATCH] mtd: nand: raw: atmel: remove unnecessary return value Marcus Folkesson
2024-08-09 12:25 ` Alexander Dahl
2024-08-09 12:36   ` Michael Nazzareno Trimarchi
2024-08-09 13:05   ` Marcus Folkesson
2024-08-30  6:59 ` Marcus Folkesson
2024-08-30  7:05   ` Michael Nazzareno Trimarchi
2024-12-10  7:08     ` Marcus Folkesson [this message]
2024-12-10  7:12       ` Michael Nazzareno Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1fo_xrE8jLve6pK@gmail.com \
    --to=marcus.folkesson@gmail.com \
    --cc=ada@thorsis.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=eugen.hristev@collabora.com \
    --cc=ivprusov@salutedevices.com \
    --cc=michael@amarulasolutions.com \
    --cc=seanga2@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.