From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Sandipan Das <sandipan.das@amd.com>, Xu Yang <xu.yang_2@nxp.com>,
Benjamin Gray <bgray@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf jevents: Fix build issue in '*/' in event descriptions
Date: Tue, 10 Dec 2024 10:15:30 -0300 [thread overview]
Message-ID: <Z1g-8ggHQ8MoVNhx@x1> (raw)
In-Reply-To: <CAP-5=fUze9j8etq-17L0dWVoYfE-bA+61wrEAXN9vJSCj9dCbw@mail.gmail.com>
On Mon, Dec 09, 2024 at 01:29:15PM -0800, Ian Rogers wrote:
> On Mon, Dec 9, 2024 at 12:28 PM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > On Mon, Dec 09, 2024 at 10:35:34AM -0800, Ian Rogers wrote:
> > > On Wed, Nov 13, 2024 at 8:56 AM Ian Rogers <irogers@google.com> wrote:
> > > >
> > > > For big string offsets we output comments for what string the offset
> > > > is for. If the string contains a '*/' as seen in Intel Arrowlake event
> > > > descriptions, then this causes C parsing issues for the generated
> > > > pmu-events.c. Catch such '*/' values and escape to avoid this.
> > > >
> > > > Signed-off-by: Ian Rogers <irogers@google.com>
> > >
> > > Ping.
> >
> > A fixes: is missing, probably this should go via perf-tools, i.e. for
> > this merge window?
>
> We don't yet have arrowlake events/metrics, should there be a fixes?
Ok, thanks for the clarification.
> I'm just preparing the patches for the latest vendor json from Intel,
> but they will depend on this. I suspect given the size of the vendor
> json it will miss the current merge window.
Probably best to have big patches via perf-tools-next at this point in
time.
- Arnaldo
next prev parent reply other threads:[~2024-12-10 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 16:55 [PATCH v1] perf jevents: Fix build issue in '*/' in event descriptions Ian Rogers
2024-12-09 18:35 ` Ian Rogers
2024-12-09 20:28 ` Arnaldo Carvalho de Melo
2024-12-09 21:29 ` Ian Rogers
2024-12-10 13:15 ` Arnaldo Carvalho de Melo [this message]
2024-12-10 19:17 ` Arnaldo Carvalho de Melo
2024-12-10 19:24 ` Ian Rogers
2024-12-10 19:58 ` Arnaldo Carvalho de Melo
2024-12-10 20:01 ` Arnaldo Carvalho de Melo
2024-12-10 20:21 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1g-8ggHQ8MoVNhx@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bgray@linux.ibm.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.