From: Mike Snitzer <snitzer@kernel.org>
To: LongPing Wei <weilongping@oppo.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Damien Le Moal <dlemoal@kernel.org>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"ebiggers@google.com" <ebiggers@google.com>
Subject: Re: dm-crypt: set max_io_len as chunk_sectors of zoned device
Date: Tue, 10 Dec 2024 11:20:01 -0500 [thread overview]
Message-ID: <Z1hqMSI-got7s_Od@kernel.org> (raw)
In-Reply-To: <ec6f2bb7-95d8-4c1b-9654-4c597e1f0da4@oppo.com>
On Mon, Nov 25, 2024 at 03:49:01PM +0800, LongPing Wei wrote:
> On 2024/11/25 14:11, Christoph Hellwig wrote:
> > On Mon, Nov 25, 2024 at 03:07:24PM +0900, Damien Le Moal wrote:
> > > 100% agree. But in this case, dm-crypt sees a single BIO which gets split when
> > > submitted to the underlying device. But the split issues the requests in
> > > reverse order, which breaks write ordering.
> >
> > I'd like to see verification of this. People who send these kinds of
> > odd old kernel reports tend to have weird patches applied to their tree
> > as well.
> >
> > Without an upstream reproducer that actually shows issues I think
> > this can be safely ignored.
> >
> Thanks for your suggestions.
> I will try to make another patch of fault injection to reproduce it on qemu.
>
If/when you do find it is relevant for latest upstream and/or
6.6-only: please add a "Fixes:" tag and also be explicit about which
kernel(s) your fix is applicable to.
Mike
next prev parent reply other threads:[~2024-12-10 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 5:58 [PATCH] dm-crypt: set max_io_len as chunk_sectors of zoned device 韦龙平(Groot)
2024-11-25 6:01 ` Christoph Hellwig
2024-11-25 6:07 ` Damien Le Moal
2024-11-25 6:11 ` Christoph Hellwig
2024-11-25 7:49 ` LongPing Wei
2024-12-10 16:20 ` Mike Snitzer [this message]
2024-12-11 2:00 ` LongPing Wei
2024-11-25 7:43 ` [PATCH] " LongPing Wei
2024-11-25 6:03 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1hqMSI-got7s_Od@kernel.org \
--to=snitzer@kernel.org \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=snitzer@redhat.com \
--cc=weilongping@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.