Re: [PATCH RFC liburing 1/2] Add IORING_OP_CLONE/EXEC support

[Josh Triplett <josh@joshtriplett.org>]

On Mon, Dec 09, 2024 at 06:44:20PM -0500, Gabriel Krisman Bertazi wrote:
> Signed-off-by: Gabriel Krisman Bertazi <krisman@suse.de>

One issue noted below; with that fixed:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> --- a/src/include/liburing.h
> +++ b/src/include/liburing.h
> @@ -1229,6 +1229,31 @@ IOURINGINLINE void io_uring_prep_socket_direct_alloc(struct io_uring_sqe *sqe,
>  	__io_uring_set_target_fixed_file(sqe, IORING_FILE_INDEX_ALLOC - 1);
>  }
>  
> +static inline void io_uring_prep_clone(struct io_uring_sqe *sqe)
> +{
> +	io_uring_prep_rw(IORING_OP_CLONE, sqe, 0, NULL, 0, 0);
> +}
> +
> +static inline void io_uring_prep_execveat(struct io_uring_sqe *sqe, int dfd,
> +					  const char *filename, char *const *argv,
> +					  char *const *envp, int flags)
> +{
> +	io_uring_prep_rw(IORING_OP_EXECVEAT, sqe, dfd, filename, 0, 0);
> +	sqe->addr2 = (unsigned long)(void *)argv;
> +	sqe->addr3 = (unsigned long)(void *)envp;
> +	sqe->execve_flags = flags;
> +}
> +
> +static inline void io_uring_prep_exec(struct io_uring_sqe *sqe,
> +				      const char *filename, char *const *argv,
> +                                      char *const *envp)
> +{
> +       io_uring_prep_rw(IORING_OP_EXECVEAT, sqe, 0, filename, 0, 0);

Shouldn't this helper use AT_FDCWD, rather than 0?