All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Rik van Riel <riel@surriel.com>,
	Omar Sandoval <osandov@meta.com>
Subject: Re: [PATCH printk v1 1/2] printk: Remove redundant deferred check in vprintk()
Date: Wed, 11 Dec 2024 15:24:25 +0100	[thread overview]
Message-ID: <Z1mgmT8HlkGR6UEN@pathway.suse.cz> (raw)
In-Reply-To: <20241209111746.192559-2-john.ogness@linutronix.de>

On Mon 2024-12-09 12:23:45, John Ogness wrote:
> The helper printk_get_console_flush_type() is already calling
> is_printk_legacy_deferred() to determine if legacy printing is
> to be offloaded. Therefore there is no need for vprintk() to
> perform this check as well. Remove the redundant check from
> vprintk().
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Great catch!

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

  reply	other threads:[~2024-12-11 14:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 11:17 [PATCH printk v1 0/2] Fix ABBA deadlock for legacy printing with cpu_sync John Ogness
2024-12-09 11:17 ` [PATCH printk v1 1/2] printk: Remove redundant deferred check in vprintk() John Ogness
2024-12-11 14:24   ` Petr Mladek [this message]
2024-12-09 11:17 ` [PATCH printk v1 2/2] printk: Defer legacy printing when holding printk_cpu_sync John Ogness
2024-12-11 15:03   ` Petr Mladek
2024-12-11 16:48     ` John Ogness
2024-12-16 14:17       ` Petr Mladek
2025-01-10 11:22         ` John Ogness
2025-01-10 15:30           ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1mgmT8HlkGR6UEN@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@meta.com \
    --cc=riel@surriel.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.