From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Gabriel Krisman Bertazi <krisman@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"hanqi@vivo.com" <hanqi@vivo.com>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: Unicode conversion issue
Date: Wed, 11 Dec 2024 21:53:48 +0000 [thread overview]
Message-ID: <Z1oJ7PgRvLyctn0X@google.com> (raw)
In-Reply-To: <CAHk-=wi+ZB4fNiMTHOYo2__-NnBXryQwxJ_bHN+cUDsfBBt_MA@mail.gmail.com>
On 12/11, Linus Torvalds wrote:
> On Wed, 11 Dec 2024 at 13:11, Gabriel Krisman Bertazi <krisman@suse.de> wrote:
> >
> > This solves it for directories with inlined dirents
> > (FI_INLINE_DENTRY). but for large directories, we use fname->hash to
> > find the right block to start the search.
>
> Grr. Dammit, the hash should always have been the original hash of the
> original actual case-preserving entry.
>
> Oh well. I'll continue to just absolutely hate case-folding, because
> while I suspect that it *could* be done correctly, I have yet to ever
> actually see any filesystem that did so.
Casefolding supports f2fs and ext4 per Android request, and only f2fs
constructs hash-based directory structure. If we use hash of the
case-preserving entry, we had no easy solution to distinguish file_A and file_a.
One possible way might be searching only filename sequentially through
the entire dentry list, if we fail to find the new encoded entry. But, it may
need a huge surgery to make it work.
>
> Linus
next prev parent reply other threads:[~2024-12-11 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 15:46 Unicode conversion issue Jaegeuk Kim
2024-12-11 16:08 ` Gabriel Krisman Bertazi
2024-12-11 17:08 ` Jaegeuk Kim
2024-12-11 19:45 ` Gabriel Krisman Bertazi
2024-12-11 19:58 ` Linus Torvalds
2024-12-11 20:18 ` Linus Torvalds
2024-12-11 21:10 ` Gabriel Krisman Bertazi
2024-12-11 21:25 ` Linus Torvalds
2024-12-11 21:53 ` Jaegeuk Kim [this message]
2024-12-11 21:56 ` Linus Torvalds
2024-12-11 22:01 ` Jaegeuk Kim
2024-12-11 22:09 ` Linus Torvalds
2024-12-11 21:13 ` Jaegeuk Kim
2024-12-11 19:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1oJ7PgRvLyctn0X@google.com \
--to=jaegeuk@kernel.org \
--cc=hanqi@vivo.com \
--cc=krisman@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.