From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C077E77180 for ; Wed, 11 Dec 2024 22:42:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F78D10E93A; Wed, 11 Dec 2024 22:42:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="IEwt1VuS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5E2B10E93A for ; Wed, 11 Dec 2024 22:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733956969; x=1765492969; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GHp8gKzlju5+t/8rxZn7k3szuHJiz8y39Kjsdgy1LBg=; b=IEwt1VuSzK6BeMB9CEAt35SnX1CTue+Pw6096IoWZmR3WkUOGM6pE36t 0bnhjn1oBSaFry2A14tjFxNMTLkr4fL37y+UwaoW36guvS+4bJ4k77zid dvRZJScC+HS/VVs395wGwrDBXXTu6Hs/SYf2puNCFsKV9Mkc8USSXvMUQ eqjAaMkt6YbTIn+LoEk2eKOZpUqKYzbdlv9jgeDgnMwL8lEB45c1hg43L 1KrqyghHcNyk+pB3vuUCPODKwO9eZJHRWU2xOwHfXgo94BQ2d2hvPgO0K +gmOOgOKp5e/4AQcycWerHOwtkHgNKefNaswwthHza/xGYMyHYTAb6WjR A==; X-CSE-ConnectionGUID: z8iSylLcS5qZHziaJgGkQQ== X-CSE-MsgGUID: j7Jazp7aTZ6EbgGB5bqgUg== X-IronPort-AV: E=McAfee;i="6700,10204,11283"; a="34260415" X-IronPort-AV: E=Sophos;i="6.12,226,1728975600"; d="scan'208";a="34260415" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2024 14:42:48 -0800 X-CSE-ConnectionGUID: AHfrj1FuQNG5X4o9bHfYCQ== X-CSE-MsgGUID: bLwslWqUS/G+9jk/jlQ5Og== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="119228408" Received: from jkrzyszt-mobl2.ger.corp.intel.com (HELO intel.com) ([10.245.246.26]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2024 14:42:46 -0800 Date: Wed, 11 Dec 2024 23:42:41 +0100 From: Andi Shyti To: Krzysztof Karas Cc: intel-gfx@lists.freedesktop.org, Michal Wajdeczko , Andi Shyti , Imre Deak , Jani Nikula , Rodrigo Vivi Subject: Re: [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Krzysztof, On Wed, Dec 11, 2024 at 02:52:20PM +0000, Krzysztof Karas wrote: > Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(), > use error pointers with informative codes. This will also trigger IS_ERR() in > current caller (intel_dp_tunnerl_mgr_init()) instead of bypassing it via NULL > pointer. > > v2: use error codes inside drm_dp_tunnel_mgr_create() instead of handling > on caller's side (Michal, Imre) > > Signed-off-by: Krzysztof Karas Please: 1. run checkpatch.pl before sending patches. 2. don't ignore previous reviews: I asked you to add the fixes tag and two Cc 3. run checkpatch.pl before sending patches. 4. Because this is a fix you should Cc also the stable mailing list (for real!). 5. Find the proper maintainers to Cc, this patch is outside Intel's territory; consider using, but not strictly, get_maintainer.pl And, in case you forget: 6. run checkpatch.pl before sending patches. Looking forward for a v3. Andi