From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>,
linux-arm-kernel@lists.infradead.org, Dave.Martin@arm.com,
will@kernel.org
Subject: Re: [PATCH v2] arm64: signal: Ensure signal delivery failure is recoverable
Date: Thu, 12 Dec 2024 17:10:14 +0000 [thread overview]
Message-ID: <Z1sY9tIsAZ84W93-@arm.com> (raw)
In-Reply-To: <5db7f7a0-1d3c-4bbd-ad2b-124bf54f49ef@sirena.org.uk>
On Thu, Dec 12, 2024 at 04:47:46PM +0000, Mark Brown wrote:
> On Tue, Dec 10, 2024 at 04:09:40PM +0000, Kevin Brodsky wrote:
> > While at it, also take care of copy_siginfo_to_user(): since it may
> > fail, we shouldn't be calling it after setup_return() either. Call
> > it before setup_return() instead, and move the setting of X1/X2
> > inside setup_return() where it belongs (after the "point of no
> > failure").
>
> > Fixes: eaf62ce1563b ("arm64/signal: Set up and restore the GCS context for signal handlers")
>
> Presumably we also need a Fixes for whatever introduced the above copy.
Hmm, it was like this from the beginning. If we are to do a cc stable to
the oldest maintained LTS, I'd rather have a separate patch for
copy_siginfo_to_user(), it doesn't make much sense to backport a GCS
patch to early kernels.
--
Catalin
next prev parent reply other threads:[~2024-12-12 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 16:09 [PATCH v2] arm64: signal: Ensure signal delivery failure is recoverable Kevin Brodsky
2024-12-12 14:35 ` Dave Martin
2024-12-12 16:01 ` Kevin Brodsky
2024-12-12 16:47 ` Mark Brown
2024-12-12 17:10 ` Catalin Marinas [this message]
2024-12-12 17:26 ` Mark Brown
2024-12-12 17:51 ` Catalin Marinas
2024-12-13 9:15 ` Kevin Brodsky
2024-12-13 14:55 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1sY9tIsAZ84W93-@arm.com \
--to=catalin.marinas@arm.com \
--cc=Dave.Martin@arm.com \
--cc=broonie@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.