All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: davidgow@google.com, npitre@baylibre.com,
	stern@rowland.harvard.edu, u.kleine-koenig@baylibre.com,
	skhan@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
	rbm@suse.com, linux-kselftest@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] lib/math: Add int_sqrt test suite
Date: Thu, 12 Dec 2024 13:18:12 -0500	[thread overview]
Message-ID: <Z1so5J9BaXYUF2fo@x13> (raw)
In-Reply-To: <20241211231816.9857d14e07251165e247eb51@linux-foundation.org>

On Wed, Dec 11, 2024 at 11:18:16PM -0800, Andrew Morton wrote: 
> my x86_64 allmodconfig build says
> 
>   AR      built-in.a
>   AR      vmlinux.a
> error: the following would cause module name conflict:
>   lib/math/tests/int_pow_kunit.ko
>   lib/math/tests/int_pow_kunit.ko
> make[1]: *** [/usr/src/25/Makefile:1925: modules_check] Error 1
> 
Hi Andrew,

Thank you for your time and pointing out the issue. The duplicate entry
for int_pow_kunit in lib/math/Makefile and lib/math/tests/Makefile stems
from my attempt to align this patch with another[1] I had authored in a
series by David Gow that moves all lib/math/ KUnit tests to lib/math/tests/.

Since that series hasn’t landed yet, I’ll update this patch by reverting to the
current mainline approach, keeping the object file assignment in lib/math/Makefile.
This avoids assuming the approach in the David's patch series and prevents conflicts.
Once both patches are merged, I'll create a follow-up patch to align everything properly.

I apologize for the confusion and back-and-forth on this patch.
In reviewing your earlier feedback from v3 of this patch[2], I now realize
what you were referring to regarding the conflict. At the time, I failed to
fully understand the issue.

I appreciate your patience, and I’ll do my best to resolve this in a way that
minimizes further disruption.

[1] https://lore.kernel.org/all/20241202075545.3648096-2-davidgow@google.com/
[2] https://lore.kernel.org/all/20241031173941.3487ccbfd7421d81d9b0cb97@linux-foundation.org/

Best,

Felipe

      reply	other threads:[~2024-12-12 18:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  2:12 [PATCH v6] lib/math: Add int_sqrt test suite Luis Felipe Hernandez
2024-12-12  7:18 ` Andrew Morton
2024-12-12 18:18   ` Luis Felipe Hernandez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1so5J9BaXYUF2fo@x13 \
    --to=luis.hernandez093@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davidgow@google.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=npitre@baylibre.com \
    --cc=rbm@suse.com \
    --cc=skhan@linuxfoundation.org \
    --cc=stern@rowland.harvard.edu \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.