From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com, stable@kernel.org,
Sam Bobrowicz <sam@elite-embedded.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
"open list:V4L2 CAMERA SENSOR DRIVERS"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH v2] media: ov5640: fix get_light_freq on auto
Date: Fri, 13 Dec 2024 08:54:45 +0000 [thread overview]
Message-ID: <Z1v2VRzgUVpHZvXR@kekkonen.localdomain> (raw)
In-Reply-To: <2e79be9185cbb0dbe40e670eee996cf290bab0a6.1732264079.git.michal.simek@amd.com>
Hi Michal,
Thanks for the patch.
On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote:
> From: Sam Bobrowicz <sam@elite-embedded.com>
>
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz.
>
> Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver")
> Signed-off-by: Sam Bobrowicz <sam@elite-embedded.com>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Cc: <stable@kernel.org>
Cc: stable@vger.kernel.org
And right after the Fixes: tag.
I fixed it this time.
> ---
>
> Changes in v2:
> - add Fixes tag and cc stable
>
> drivers/media/i2c/ov5640.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index c1d3fce4a7d3..8566bc2edde9 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
> light_freq = 50;
> } else {
> /* 60Hz */
> + light_freq = 60;
> }
> }
>
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2024-12-13 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 8:28 [PATCH v2] media: ov5640: fix get_light_freq on auto Michal Simek
2024-12-13 8:54 ` Sakari Ailus [this message]
2024-12-13 10:30 ` Michal Simek
2024-12-13 11:12 ` Greg Kroah-Hartman
2024-12-13 12:37 ` Michal Simek
2024-12-14 18:24 ` Sakari Ailus
2024-12-14 18:41 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1v2VRzgUVpHZvXR@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=git@xilinx.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=sam@elite-embedded.com \
--cc=slongerbeam@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.