From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: devicetree@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: How to check (an updated) schema if make dt_binding_check fails already?
Date: Fri, 13 Dec 2024 07:56:42 +0200 [thread overview]
Message-ID: <Z1vMmlr1l7hcTEWA@smile.fi.intel.com> (raw)
In-Reply-To: <Z1skz3Dmz3mPIskX@smile.fi.intel.com>
On Thu, Dec 12, 2024 at 08:00:47PM +0200, Andy Shevchenko wrote:
>
> Hi!
>
> I would like to extend an existing schema, the checker currently (on Debian
> unstable) fails with the recent in-kernel schema. What should I do?
>
> $ make dt_binding_check DT_SCHEMA_FILES=/usb/snps,dwc3.yaml
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> Traceback (most recent call last):
> File "/usr/bin/dt-mk-schema", line 8, in <module>
> sys.exit(main())
> ^^^^^^
> File "/usr/lib/python3/dist-packages/dtschema/mk_schema.py", line 28, in main
> schemas = dtschema.DTValidator(args.schemas).schemas
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/lib/python3/dist-packages/dtschema/validator.py", line 363, in __init__
> self.make_property_type_cache()
> File "/usr/lib/python3/dist-packages/dtschema/validator.py", line 420, in make_property_type_cache
> self.props, self.pat_props = get_prop_types(self.schemas)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/lib/python3/dist-packages/dtschema/validator.py", line 187, in get_prop_types
> del props[r'^[a-z][a-z0-9\-]*$']
> ~~~~~^^^^^^^^^^^^^^^^^^^^^^^
> KeyError: '^[a-z][a-z0-9\\-]*$'
> make[2]: *** [Documentation/devicetree/bindings/Makefile:63: Documentation/devicetree/bindings/processed-schema.json] Error 1
> make[2]: *** Deleting file 'Documentation/devicetree/bindings/processed-schema.json'
> make[1]: *** Makefile:1509: dt_binding_schemas] Error 2
> make: *** [Makefile:251: __sub-make] Error 2
FWIW, this traceback happens independently on presence or content of
the DT_SCHEMA_FILE variable.
So, any suggestions, please? Can this be fixed rather sooner than later?
> Tree: Linux Next next-20241212
>
> DT schema:
> $ apt list dt-schema*
> dt-schema/unstable,unstable,now 2023.11-3 all [installed]
>
> Library:
> $ apt list python3-libfdt*
> python3-libfdt/testing,testing,unstable,now 1.7.0-2+b2 amd64 [installed]
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-13 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 18:00 How to check (an updated) schema if make dt_binding_check fails already? Andy Shevchenko
2024-12-13 5:56 ` Andy Shevchenko [this message]
2024-12-13 9:57 ` Krzysztof Kozlowski
2024-12-13 8:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1vMmlr1l7hcTEWA@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.