From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, namhyung@kernel.org,
tim.c.chen@linux.intel.com, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] perf stat: Fix trailing comma when there is no metric unit
Date: Thu, 26 Dec 2024 12:20:32 -0300 [thread overview]
Message-ID: <Z210QHEkCXUlekN8@x1> (raw)
In-Reply-To: <CAP-5=fUfPnkS0HS1dMx2uR-a4GPfk4E4nD85rUtRUbVcETtY9g@mail.gmail.com>
On Thu, Dec 12, 2024 at 12:01:00AM -0800, Ian Rogers wrote:
> On Tue, Dec 10, 2024 at 10:42 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > On Tue, Nov 12, 2024 at 04:00:40PM +0000, James Clark wrote:
> > > The first commit is failing on Arm and I think the fix should stop more
> > > trailing comma issues which keep happening.
> > >
> > > The second one I just noticed when looking at it. I don't feel strongly
> > > about it so not sure if we should do it or not, but seems like the empty
> > > metric-units exclusion from the JSON should be consistent if we're going
> > > to have it at all.
> > >
> > > Changes since v2:
> > > * Do more documentation and tidyups around struct outstate
> >
> > Ian, have you had the chance of going over this series?
>
> It looks good to me, I particularly appreciate the additional
Indeed.
> comments/documentation. Tested with sanitizers.
>
> Tested-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2024-12-26 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 16:00 [PATCH v3 0/5] perf stat: Fix trailing comma when there is no metric unit James Clark
2024-11-12 16:00 ` [PATCH v3 1/5] " James Clark
2024-11-12 16:00 ` [PATCH v3 2/5] perf stat: Also hide metric-units from JSON when event didn't run James Clark
2024-11-12 16:00 ` [PATCH v3 3/5] perf stat: Remove empty new_line_metric function James Clark
2024-11-12 16:00 ` [PATCH v3 4/5] perf stat: Document and simplify interval timestamps James Clark
2024-11-12 16:00 ` [PATCH v3 5/5] perf stat: Document and clarify outstate members James Clark
2024-12-10 18:42 ` [PATCH v3 0/5] perf stat: Fix trailing comma when there is no metric unit Arnaldo Carvalho de Melo
2024-12-12 8:01 ` Ian Rogers
2024-12-26 15:20 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z210QHEkCXUlekN8@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tim.c.chen@linux.intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.