From: Mohamed Khalfella <khalfella@gmail.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Wang Jiang" <jiangwang@kylinos.cn>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: endpoint: Set RX DMA channel to NULL after freeing it
Date: Thu, 26 Dec 2024 09:51:37 -0800 [thread overview]
Message-ID: <Z22XqedgvDYsc-QR@ceto> (raw)
In-Reply-To: <20241226163121.n2itccd4glm6vum4@thinkpad>
On 2024-12-26 22:01:21 +0530, Manivannan Sadhasivam wrote:
> On Sat, Dec 21, 2024 at 09:34:42AM -0800, Mohamed Khalfella wrote:
> > Fix a small bug in pci-epf-test driver. When requesting TX DMA channel
> > fails, free already allocated RX channel and set it to NULL.
> >
>
> Patch description should accurately describe what the patch does. Here, the
> patch is fixing the NULL ptr assignment to dma_chan_rx pointer and that's it.
>
> Reword it as such.
PCI: endpoint: pci-epf-test: Fix NULL ptr assignment to dma_chan_rx
When allocating dma_chan_tx fails set dma_chan_rx to NULL after it is
freed.
How about the updated subject line and commit message above?
next prev parent reply other threads:[~2024-12-26 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 3:00 [PATCH] PCI: endpoint: Set RX DMA channel to NULL aftre freeing it Mohamed Khalfella
2024-12-21 8:24 ` Niklas Cassel
2024-12-21 17:34 ` [PATCH v2] PCI: endpoint: Set RX DMA channel to NULL after " Mohamed Khalfella
2024-12-26 16:31 ` Manivannan Sadhasivam
2024-12-26 17:51 ` Mohamed Khalfella [this message]
2024-12-27 13:59 ` Manivannan Sadhasivam
2024-12-27 16:08 ` [PATCH v3] PCI: endpoint: pci-epf-test: Fix NULL ptr assignment to dma_chan_rx Mohamed Khalfella
2024-12-30 7:26 ` Manivannan Sadhasivam
2024-12-30 18:36 ` Mohamed Khalfella
2025-01-15 11:25 ` Krzysztof Wilczyński
2024-12-21 19:18 ` [PATCH] PCI: endpoint: Set RX DMA channel to NULL aftre freeing it Markus Elfring
2024-12-21 20:00 ` Mohamed Khalfella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z22XqedgvDYsc-QR@ceto \
--to=khalfella@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jiangwang@kylinos.cn \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.