From: shejialuo <shejialuo@gmail.com>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>,
Karthik Nayak <karthik.188@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/1] ref: add object check for regular ref
Date: Fri, 27 Dec 2024 21:58:45 +0800 [thread overview]
Message-ID: <Z26ylU3umgLiwuZT@ArchLinux> (raw)
In-Reply-To: <Z26uXy31q83dyxvD@ArchLinux>
On Fri, Dec 27, 2024 at 09:40:47PM +0800, shejialuo wrote:
> Hi All:
>
> When I implement the code for packed ref content checks, I somehow
> notice that I ignore checks for the object. In the first glance, I think
> I could make this patch in the first of my packed ref content check
> series. However, this is not a good idea which may cause the reviewers
> more overhead.
>
> And this patch aims at checking whether the object exists and whether
> the type of the object is correct.
>
> Thanks,
> Jialuo
>
> shejialuo (1):
> ref: add object check for regular ref
>
> refs/files-backend.c | 50 ++++++++++++++++++++++++++++--------
> t/t0602-reffiles-fsck.sh | 55 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 95 insertions(+), 10 deletions(-)
>
> --
> 2.47.1
>
Forget to tell Junio, this patch is based on the latest master branch.
I don't use the "sj/refs-content-check" due to there are some conflicts
when using "is_promisor_object" in the latest master branch.
next prev parent reply other threads:[~2024-12-27 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 13:40 [PATCH 0/1] ref: add object check for regular ref shejialuo
2024-12-27 13:42 ` [PATCH 1/1] " shejialuo
2024-12-27 13:58 ` shejialuo [this message]
2025-01-05 6:30 ` [PATCH 0/1] " shejialuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z26ylU3umgLiwuZT@ArchLinux \
--to=shejialuo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.