Re: [PATCH v3 6/7] tools/libs: add a new libxenmanage library

["Anthony PERARD" <anthony.perard@vates.tech>]

On Fri, Dec 13, 2024 at 05:24:20PM +0100, Juergen Gross wrote:
> diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h
> new file mode 100644
> index 0000000000..5d169693b0
> --- /dev/null
> +++ b/tools/include/xenmanage.h
> @@ -0,0 +1,92 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */

This should read "LGPL-2.1-only".

> diff --git a/tools/libs/manage/core.c b/tools/libs/manage/core.c
> new file mode 100644
> index 0000000000..b5fa67b036
> --- /dev/null
> +++ b/tools/libs/manage/core.c
> @@ -0,0 +1,168 @@

> +static int xenmanage_do_domctl_get_domain_state(xenmanage_handle *hdl,
> +                                                unsigned int domid_in,
> +                                                unsigned int *domid_out,
> +                                                unsigned int *state,
> +                                                uint64_t *unique_id)
> +{
> +    struct xen_domctl *buf;
> +    int saved_errno;
> +    int ret;
> +
> +    buf = xencall_alloc_buffer(hdl->xcall, sizeof(*buf));
> +    if ( !buf )
> +    {
> +        errno = ENOMEM;

Is this necessary? Isn't xencall_alloc_buffer() going to set `errno`? Or
is it to overwrite `errno` set by system calls which could be other than
ENOMEM?

> +        return -1;
> +    }

Otherwise, patch looks fine to me: Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech