All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	 Anup Patel <anup@brainfault.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Paolo Bonzini <pbonzini@redhat.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	 Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	 linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	 kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	 Andrew Jones <ajones@ventanamicro.com>,
	James Houghton <jthoughton@google.com>,
	 Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v4 00/16] KVM: selftests: "tree" wide overhauls
Date: Mon, 16 Dec 2024 14:33:24 -0800	[thread overview]
Message-ID: <Z2CqtL1R0-368hO-@google.com> (raw)
In-Reply-To: <20241128005547.4077116-1-seanjc@google.com>

On Wed, Nov 27, 2024, Sean Christopherson wrote:
> Two separate series (mmu_stress_test[1] and $ARCH[2]), posted as one to
> avoid unpleasant conflicts, and because I hope to land both in kvm/next
> shortly after 6.12-rc1 since they impact all of KVM selftests.
> 
> mmu_stress_test
> ---------------
> Convert the max_guest_memory_test into a more generic mmu_stress_test.
> The basic gist of the "conversion" is to have the test do mprotect() on
> guest memory while vCPUs are accessing said memory, e.g. to verify KVM
> and mmu_notifiers are working as intended.
> 
> The original plan was that patch 3 would be a single patch, but things
> snowballed in order to rework vcpu_get_reg() to return a value instead
> of using an out-param.  Having to define a variable just to bump the
> program counter on arm64 annoyed me.
> 
> $ARCH
> -----
> Play nice with treewrite builds of unsupported architectures, e.g. arm
> (32-bit), as KVM selftests' Makefile doesn't do anything to ensure the
> target architecture is actually one KVM selftests supports.
> 
> The last two patches are opportunistic changes (since the above Makefile
> change will generate conflicts everywhere) to switch to using $(ARCH)
> instead of the target triple for arch specific directories, e.g. arm64
> instead of aarch64, mainly so as not to be different from the rest of
> the kernel.

Paolo,

Unless you or someone else have concerns, can you apply this to kvm/next sooner
than later?  I'd like to start applying selftests changes for 6.14 and don't want
generate conflicts, and I really don't want to have to rebase and push this series
out again.

Thanks!

-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	 Anup Patel <anup@brainfault.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Paolo Bonzini <pbonzini@redhat.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	 Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	 linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	 kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	 Andrew Jones <ajones@ventanamicro.com>,
	James Houghton <jthoughton@google.com>,
	 Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v4 00/16] KVM: selftests: "tree" wide overhauls
Date: Mon, 16 Dec 2024 14:33:24 -0800	[thread overview]
Message-ID: <Z2CqtL1R0-368hO-@google.com> (raw)
In-Reply-To: <20241128005547.4077116-1-seanjc@google.com>

On Wed, Nov 27, 2024, Sean Christopherson wrote:
> Two separate series (mmu_stress_test[1] and $ARCH[2]), posted as one to
> avoid unpleasant conflicts, and because I hope to land both in kvm/next
> shortly after 6.12-rc1 since they impact all of KVM selftests.
> 
> mmu_stress_test
> ---------------
> Convert the max_guest_memory_test into a more generic mmu_stress_test.
> The basic gist of the "conversion" is to have the test do mprotect() on
> guest memory while vCPUs are accessing said memory, e.g. to verify KVM
> and mmu_notifiers are working as intended.
> 
> The original plan was that patch 3 would be a single patch, but things
> snowballed in order to rework vcpu_get_reg() to return a value instead
> of using an out-param.  Having to define a variable just to bump the
> program counter on arm64 annoyed me.
> 
> $ARCH
> -----
> Play nice with treewrite builds of unsupported architectures, e.g. arm
> (32-bit), as KVM selftests' Makefile doesn't do anything to ensure the
> target architecture is actually one KVM selftests supports.
> 
> The last two patches are opportunistic changes (since the above Makefile
> change will generate conflicts everywhere) to switch to using $(ARCH)
> instead of the target triple for arch specific directories, e.g. arm64
> instead of aarch64, mainly so as not to be different from the rest of
> the kernel.

Paolo,

Unless you or someone else have concerns, can you apply this to kvm/next sooner
than later?  I'd like to start applying selftests changes for 6.14 and don't want
generate conflicts, and I really don't want to have to rebase and push this series
out again.

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	 Anup Patel <anup@brainfault.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Paolo Bonzini <pbonzini@redhat.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	 Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	 linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	 kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	 Andrew Jones <ajones@ventanamicro.com>,
	James Houghton <jthoughton@google.com>,
	 Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v4 00/16] KVM: selftests: "tree" wide overhauls
Date: Mon, 16 Dec 2024 14:33:24 -0800	[thread overview]
Message-ID: <Z2CqtL1R0-368hO-@google.com> (raw)
In-Reply-To: <20241128005547.4077116-1-seanjc@google.com>

On Wed, Nov 27, 2024, Sean Christopherson wrote:
> Two separate series (mmu_stress_test[1] and $ARCH[2]), posted as one to
> avoid unpleasant conflicts, and because I hope to land both in kvm/next
> shortly after 6.12-rc1 since they impact all of KVM selftests.
> 
> mmu_stress_test
> ---------------
> Convert the max_guest_memory_test into a more generic mmu_stress_test.
> The basic gist of the "conversion" is to have the test do mprotect() on
> guest memory while vCPUs are accessing said memory, e.g. to verify KVM
> and mmu_notifiers are working as intended.
> 
> The original plan was that patch 3 would be a single patch, but things
> snowballed in order to rework vcpu_get_reg() to return a value instead
> of using an out-param.  Having to define a variable just to bump the
> program counter on arm64 annoyed me.
> 
> $ARCH
> -----
> Play nice with treewrite builds of unsupported architectures, e.g. arm
> (32-bit), as KVM selftests' Makefile doesn't do anything to ensure the
> target architecture is actually one KVM selftests supports.
> 
> The last two patches are opportunistic changes (since the above Makefile
> change will generate conflicts everywhere) to switch to using $(ARCH)
> instead of the target triple for arch specific directories, e.g. arm64
> instead of aarch64, mainly so as not to be different from the rest of
> the kernel.

Paolo,

Unless you or someone else have concerns, can you apply this to kvm/next sooner
than later?  I'd like to start applying selftests changes for 6.14 and don't want
generate conflicts, and I really don't want to have to rebase and push this series
out again.

Thanks!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2024-12-16 22:34 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28  0:55 [PATCH v4 00/16] KVM: selftests: "tree" wide overhauls Sean Christopherson
2024-11-28  0:55 ` Sean Christopherson
2024-11-28  0:55 ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 01/16] KVM: Move KVM_REG_SIZE() definition to common uAPI header Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  8:14   ` Muhammad Usama Anjum
2024-11-28  8:14     ` Muhammad Usama Anjum
2024-11-28  8:14     ` Muhammad Usama Anjum
2024-11-28  0:55 ` [PATCH v4 02/16] KVM: selftests: Return a value from vcpu_get_reg() instead of using an out-param Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  8:25   ` Claudio Imbrenda
2024-11-28  8:25     ` Claudio Imbrenda
2024-11-28  8:25     ` Claudio Imbrenda
2024-11-28  0:55 ` [PATCH v4 03/16] KVM: selftests: Assert that vcpu_{g,s}et_reg() won't truncate Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 04/16] KVM: selftests: Check for a potential unhandled exception iff KVM_RUN succeeded Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 05/16] KVM: selftests: Rename max_guest_memory_test to mmu_stress_test Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 06/16] KVM: selftests: Only muck with SREGS on x86 in mmu_stress_test Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 07/16] KVM: selftests: Compute number of extra pages needed " Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 08/16] KVM: sefltests: Explicitly include ucall_common.h in mmu_stress_test.c Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 09/16] KVM: selftests: Enable mmu_stress_test on arm64 Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 10/16] KVM: selftests: Use vcpu_arch_put_guest() in mmu_stress_test Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 11/16] KVM: selftests: Precisely limit the number of guest loops " Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 12/16] KVM: selftests: Add a read-only mprotect() phase to mmu_stress_test Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 13/16] KVM: selftests: Verify KVM correctly handles mprotect(PROT_READ) Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55 ` [PATCH v4 14/16] KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  8:19   ` Muhammad Usama Anjum
2024-11-28  8:19     ` Muhammad Usama Anjum
2024-11-28  8:19     ` Muhammad Usama Anjum
2024-11-28  8:42   ` Andrew Jones
2024-11-28  8:42     ` Andrew Jones
2024-11-28  8:42     ` Andrew Jones
2024-11-28  0:55 ` [PATCH v4 15/16] KVM: selftests: Use canonical $(ARCH) paths for KVM selftests directories Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  8:20   ` Muhammad Usama Anjum
2024-11-28  8:20     ` Muhammad Usama Anjum
2024-11-28  8:20     ` Muhammad Usama Anjum
2024-11-28  8:25   ` Claudio Imbrenda
2024-11-28  8:25     ` Claudio Imbrenda
2024-11-28  8:25     ` Claudio Imbrenda
2024-12-02 18:47     ` Sean Christopherson
2024-12-02 18:47       ` Sean Christopherson
2024-12-02 18:47       ` Sean Christopherson
2024-11-28  8:43   ` Andrew Jones
2024-11-28  8:43     ` Andrew Jones
2024-11-28  8:43     ` Andrew Jones
2024-11-28  0:55 ` [PATCH v4 16/16] KVM: selftests: Override ARCH for x86_64 instead of using ARCH_DIR Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  0:55   ` Sean Christopherson
2024-11-28  8:20   ` Muhammad Usama Anjum
2024-11-28  8:20     ` Muhammad Usama Anjum
2024-11-28  8:20     ` Muhammad Usama Anjum
2024-12-16 22:33 ` Sean Christopherson [this message]
2024-12-16 22:33   ` [PATCH v4 00/16] KVM: selftests: "tree" wide overhauls Sean Christopherson
2024-12-16 22:33   ` Sean Christopherson
2024-12-18 21:56 ` Sean Christopherson
2024-12-18 21:56   ` Sean Christopherson
2024-12-18 21:56   ` Sean Christopherson
2024-12-18 22:12   ` Sean Christopherson
2024-12-18 22:12     ` Sean Christopherson
2024-12-18 22:12     ` Sean Christopherson
2024-12-19  2:00     ` Sean Christopherson
2024-12-19  2:00       ` Sean Christopherson
2024-12-19  2:00       ` Sean Christopherson
2024-12-19 12:51       ` Paolo Bonzini
2024-12-19 12:51         ` Paolo Bonzini
2024-12-19 12:51         ` Paolo Bonzini
2024-12-19 15:14       ` John Stoffel
2024-12-19 15:14         ` John Stoffel
2024-12-19 15:14         ` John Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2CqtL1R0-368hO-@google.com \
    --to=seanjc@google.com \
    --cc=ajones@ventanamicro.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=jthoughton@google.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=pbonzini@redhat.com \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.