Re: [Buildroot] [PATCH] boot/arm-trusted-firmware: bump to v2.12

From: "Vincent Stehlé" <vincent.stehle@arm.com>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org, Sergey Matyukevich <geomatsi@gmail.com>
Subject: Re: [Buildroot] [PATCH] boot/arm-trusted-firmware: bump to v2.12
Date: Tue, 17 Dec 2024 11:04:56 +0100	[thread overview]
Message-ID: <Z2FMyLInGBpM5lFq@debian> (raw)
In-Reply-To: <847d9076e7ae8227d486d9ef1fe08bb0@free.fr>

On Mon, Dec 16, 2024 at 10:08:46PM +0100, Julien Olivain wrote:
> Hi Vincent,
> 
> On 16/12/2024 10:04, Vincent Stehlé wrote:
> > Update trusted-firmware-a version to v2.12 and add a hash file
> > accordingly.
> > 
> > Compared to v2.11, the license has changed with the additional mention
> > of
> > files from the pydevicetree project under Apache 2.0 license.
> > As we only document the main license of TF-A, BSD-3-Clause, this change
> > has
> > no impact for us.
> > 
> > Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
> > Cc: Dick Olsson <hi@senzilla.io>
> > Cc: Sergey Matyukevich <geomatsi@gmail.com>
> 
> Thanks for the patch (and the extended testing). I applied to master.

Hi Julien,

Thanks for handling that.

> I removed the hash file for v2.11, since it is no longer needed
> here. I also see that arm_fvp_ebbr_defconfig uses TF-A v2.11 [1]
> but its patch directory [2] does not include an entry for it.
> I believe it was missing and was using the hash file I removed.
> This defconfig might be broken now. Could you double check that
> please? You might need to add back a hash file in your board
> patch directory (even if it's for an updated v2.12 version).

Thanks for pointing that out!

I see not one but two defconfigs using TF-A v2.11 without a
corresponding hash file now:

  arm_fvp_ebbr_defconfig
  rockpro64_defconfig

I will send patches to add hash files to both soon.

Fortunately I think there is no urgency, as with those defconfigs TF-A
does indeed still extract fine and all we get for now is a warning:

  WARNING: no hash file for arm-trusted-firmware-v2.11-git4.tar.gz

This is arguably a bit of a surprising behaviour when we have
BR2_DOWNLOAD_FORCE_CHECK_HASHES=y...

Best regards,
Vincent.

> 
> Best regards,
> 
> Julien.
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/blob/master/configs/arm_fvp_ebbr_defconfig#L20
> [2] https://gitlab.com/buildroot.org/buildroot/-/tree/master/board/arm/fvp-ebbr/patches
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot