From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533921E1A17; Tue, 17 Dec 2024 10:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.149.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734431825; cv=none; b=E98UtSjRIN/fD23aijLKNvifeeL78vBcvInkv2A00cQjW1I89hB6u2/sVapw4ZWu44guBKLaKBh13ic75cmOeAPKj59XO45M1hdo2OMAqEYj0V10cOOXtaIZ/ZMG0qZRlZXwl7W9U7eGBUrCTSYyPrwKyXgH/P31CWcdikHSW8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734431825; c=relaxed/simple; bh=O8dKluOujhFZHtu4NC9kbCIEXTbQRJR5JMVk02v4L/I=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l7Puj91OT7We2+468DvAIQQRP7dBrQcTmUTBmF7BULN/ni1Wv+uQJV3h9bW6usXCaiDTSLq49RlcVsgsmws3p+Ndo7j1gfMHTOViNK5il6R1x7Ed7Zv+Ddqyls5IA+W4jUOV9ezec9iDpYDZJGoZsGX31mxp0/L0BTe/EkETi5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=JHyqdCnA; arc=none smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="JHyqdCnA" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BH4pZxb025779; Tue, 17 Dec 2024 04:36:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=DncSMB8awaOalGRsmX KLNqehj2Q8AYTF94wrCAJZets=; b=JHyqdCnAmk49Rks7tVDdl3Y0WoutMvr9mB x3iG4Gih0mGgeaQ7b7y6YZuqiBWOeWqniSGkkhacOVcylwjh8Ais2tnzOBK/LMn4 L0mw7++y/sEhaKUgqkptQ2STbN8qQslOWHFUNPyAGAbUW95HpYe45bEj6R2MacLE dr3Wr5bd/vBehFbMarGrAwhRCuKkSl17WHMrxdePJ6CkIqY7VVHogsI1yu/xu+jW Wa2jZzHOPe9mMk1J+kcKIRKz7s9P5ZOc7MRlf0NKePCETF34apari5BqsJ3qElvv wKRhesX/OXcQJ4j4tQh4kn7cFQdc5GKOyJmpynrAUNV3yzmMWYUg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 43h8a237vd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 04:36:26 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.13; Tue, 17 Dec 2024 10:36:23 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1544.13 via Frontend Transport; Tue, 17 Dec 2024 10:36:23 +0000 Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPS id B0265820248; Tue, 17 Dec 2024 10:36:23 +0000 (UTC) Date: Tue, 17 Dec 2024 10:36:22 +0000 From: Charles Keepax To: Wolfram Sang CC: , Alexandre Belloni , Yiting Deng , Xianwei Zhao , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Nicolas Ferre , Claudiu Beznea , Benson Leung , Guenter Roeck , Support Opensource , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Chanwoo Choi , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , "Jerome Brunet" , Martin Blumenstingl , Eddie Huang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Vincent Shih" , Thierry Reding , Jonathan Hunter , Michal Simek , , , , , , , , , , , Subject: Re: [PATCH] rtc: use boolean values with device_init_wakeup() Message-ID: References: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> X-Proofpoint-ORIG-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-Spam-Reason: safe On Tue, Dec 17, 2024 at 08:13:26AM +0100, Wolfram Sang wrote: > device_init_wakeup() second argument is a bool type. Use proper boolean > values when calling it to match the type and to produce unambiguous code > which is easier to understand. > > Signed-off-by: Wolfram Sang > --- For the old Wolfson parts: Reviewed-by: Charles Keepax Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B78AE7716A for ; Tue, 17 Dec 2024 10:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kBIPCRT2K2/ooZZDjYBeJztoNHf99G/vvKA9yLDRkZI=; b=JS81y0iSLvmzgL RqbAkeJMY7iEANNKk1zSCndQuj2Rx4uCU6avwel+WSQgSaT870enXWg25eTy983fKrg9Uz4Sa1nqZ 2QhtU66imayQgUsGDXzs2nvH9IpzpWPQT3gus4SeuZGXaq1nVmBQR0NVeq79Kuv61ZillKhNStRG/ qYZodMJLJwwQnPmCQYpnQPbOOjcv7PpKAyKjWfl/5uc0TBXw55ZmGA9Y0CzbtXrf2lJL3K0aC2cG8 GUwwtAkr0P/u2YO/n6Y/kEhCo0Rp4PJmtY4ZC44ZzU4K6GwkjYjHarLX79ZNjuuS0QBNbWJLP7nTA TZZa7/sTSvMA0sE64yXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNUwq-0000000D8kj-2Q7x; Tue, 17 Dec 2024 10:37:04 +0000 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25] helo=mx0b-001ae601.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tNUwn-0000000D8jE-2qXp; Tue, 17 Dec 2024 10:37:03 +0000 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BH4pZxb025779; Tue, 17 Dec 2024 04:36:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=DncSMB8awaOalGRsmX KLNqehj2Q8AYTF94wrCAJZets=; b=JHyqdCnAmk49Rks7tVDdl3Y0WoutMvr9mB x3iG4Gih0mGgeaQ7b7y6YZuqiBWOeWqniSGkkhacOVcylwjh8Ais2tnzOBK/LMn4 L0mw7++y/sEhaKUgqkptQ2STbN8qQslOWHFUNPyAGAbUW95HpYe45bEj6R2MacLE dr3Wr5bd/vBehFbMarGrAwhRCuKkSl17WHMrxdePJ6CkIqY7VVHogsI1yu/xu+jW Wa2jZzHOPe9mMk1J+kcKIRKz7s9P5ZOc7MRlf0NKePCETF34apari5BqsJ3qElvv wKRhesX/OXcQJ4j4tQh4kn7cFQdc5GKOyJmpynrAUNV3yzmMWYUg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 43h8a237vd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 04:36:26 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.13; Tue, 17 Dec 2024 10:36:23 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1544.13 via Frontend Transport; Tue, 17 Dec 2024 10:36:23 +0000 Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPS id B0265820248; Tue, 17 Dec 2024 10:36:23 +0000 (UTC) Date: Tue, 17 Dec 2024 10:36:22 +0000 From: Charles Keepax To: Wolfram Sang CC: , Alexandre Belloni , Yiting Deng , Xianwei Zhao , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Nicolas Ferre , Claudiu Beznea , Benson Leung , Guenter Roeck , Support Opensource , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Chanwoo Choi , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , "Jerome Brunet" , Martin Blumenstingl , Eddie Huang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Vincent Shih" , Thierry Reding , Jonathan Hunter , Michal Simek , , , , , , , , , , , Subject: Re: [PATCH] rtc: use boolean values with device_init_wakeup() Message-ID: References: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> X-Proofpoint-ORIG-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-Spam-Reason: safe X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241217_023701_717989_6525BB5B X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2024 at 08:13:26AM +0100, Wolfram Sang wrote: > device_init_wakeup() second argument is a bool type. Use proper boolean > values when calling it to match the type and to produce unambiguous code > which is easier to understand. > > Signed-off-by: Wolfram Sang > --- For the old Wolfson parts: Reviewed-by: Charles Keepax Thanks, Charles _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6FE2E7716A for ; Tue, 17 Dec 2024 10:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DncSMB8awaOalGRsmXKLNqehj2Q8AYTF94wrCAJZets=; b=bHGKasr+WYteiUvKaf34X5pkHe U+AjG7zdAsMBniL77yKjqBMjDGs7ex6q0JM6zHgEr2ZWIGJXhLFO0Q5juipxVPcdNKClcvgMTTfO7 d78IE03V6im0rklCxrn+Gx9UTmWRheeu5vbiQFmrS8uzXlmoAiNTW4g25nzoIOjhW56weKUOncqOG 6YRb0DQXobrkziMtcPOkQs5jlcs8LNMnyffYn6LQrRBLZaGYJ+RvV1G6gZcXDUjtwTGLeyey9Rq8m QxIgimdaGnpRfnWjWlYYJ9oCPkReKnMWVeZ0LZGjWLp03O6enqNbRrugcwBibtYplFd/LADTHzmqO rGfANZCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNUxu-0000000D8yE-1FsM; Tue, 17 Dec 2024 10:38:10 +0000 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25] helo=mx0b-001ae601.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tNUwn-0000000D8jE-2qXp; Tue, 17 Dec 2024 10:37:03 +0000 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BH4pZxb025779; Tue, 17 Dec 2024 04:36:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=DncSMB8awaOalGRsmX KLNqehj2Q8AYTF94wrCAJZets=; b=JHyqdCnAmk49Rks7tVDdl3Y0WoutMvr9mB x3iG4Gih0mGgeaQ7b7y6YZuqiBWOeWqniSGkkhacOVcylwjh8Ais2tnzOBK/LMn4 L0mw7++y/sEhaKUgqkptQ2STbN8qQslOWHFUNPyAGAbUW95HpYe45bEj6R2MacLE dr3Wr5bd/vBehFbMarGrAwhRCuKkSl17WHMrxdePJ6CkIqY7VVHogsI1yu/xu+jW Wa2jZzHOPe9mMk1J+kcKIRKz7s9P5ZOc7MRlf0NKePCETF34apari5BqsJ3qElvv wKRhesX/OXcQJ4j4tQh4kn7cFQdc5GKOyJmpynrAUNV3yzmMWYUg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 43h8a237vd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 04:36:26 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.13; Tue, 17 Dec 2024 10:36:23 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1544.13 via Frontend Transport; Tue, 17 Dec 2024 10:36:23 +0000 Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPS id B0265820248; Tue, 17 Dec 2024 10:36:23 +0000 (UTC) Date: Tue, 17 Dec 2024 10:36:22 +0000 From: Charles Keepax To: Wolfram Sang Subject: Re: [PATCH] rtc: use boolean values with device_init_wakeup() Message-ID: References: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> X-Proofpoint-ORIG-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-Spam-Reason: safe X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241217_023701_717989_6525BB5B X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , linux-tegra@vger.kernel.org, Thierry Reding , Jernej Skrabec , Guenter Roeck , Jerome Brunet , linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev, linux-samsung-soc@vger.kernel.org, Samuel Holland , Kevin Hilman , Yiting Deng , Krzysztof Kozlowski , Jonathan Hunter , Chanwoo Choi , Chen-Yu Tsai , Michal Simek , Vincent Shih , Orson Zhai , linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, Piotr Wojtaszczyk , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sean Wang , Vladimir Zapolskiy , linux-mediatek@lists.infradead.org, Baolin Wang , Matthias Brugger , linux-amlogic@lists.infradead.org, Eddie Huang , Benson Leung , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Neil Armstrong , Support Opensource , patches@opensource.cirrus.com, linux-renesas-soc@vger.kernel.org, Xianwei Zhao , Chunyan Zhang , Sebastian Hesselbarth , Gregory Clement Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2024 at 08:13:26AM +0100, Wolfram Sang wrote: > device_init_wakeup() second argument is a bool type. Use proper boolean > values when calling it to match the type and to produce unambiguous code > which is easier to understand. > > Signed-off-by: Wolfram Sang > --- For the old Wolfson parts: Reviewed-by: Charles Keepax Thanks, Charles