From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH] KVM: VMX: don't include '<linux/find.h>' directly
Date: Tue, 17 Dec 2024 19:18:11 +0100 [thread overview]
Message-ID: <Z2HAY3rDzUMVmGZW@shikoro> (raw)
In-Reply-To: <Z2Goxx27WL-G-13y@google.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
Hi Sean,
> I definitely don't object to the KVM change, but the if y'all expect developers
> to actually honor the "rule", it needs to have teeth. As evidenced by a similar
> rule in arch/x86/include/asm/bitops.h that also gets ignored, an #error that's
> buried under an include guard and triggers on a macro that's never #undef'd is
> quite useless.
I went for the minimal change here. But if agreed, we could change
bitmap.h to the pattern spinlock.h is using. Similar to your suggestion,
yet with more readable names IMHO:
#define __LINUX_INSIDE_SPINLOCK_H
...
#undef __LINUX_INSIDE_SPINLOCK_H
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-12-17 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 7:05 [PATCH] KVM: VMX: don't include '<linux/find.h>' directly Wolfram Sang
2024-12-17 16:37 ` Sean Christopherson
2024-12-17 18:18 ` Wolfram Sang [this message]
2024-12-19 11:21 ` Wolfram Sang
2024-12-19 12:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2HAY3rDzUMVmGZW@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.