From: Dhaval Giani <dhaval@gianis.ca>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
lukasz.luba@arm.com, rafael.j.wysocki@intel.com,
linux-kernel@vger.kernel.org, qyousef@layalina.io,
hongyan.xia2@arm.com, pierre.gondois@arm.com,
christian.loehle@arm.com, qperret@google.com
Subject: Re: [PATCH 1/7 v2] sched/fair: Filter false overloaded_group case for EAS
Date: Tue, 17 Dec 2024 19:15:12 +0000 [thread overview]
Message-ID: <Z2HNuK_Zyfc2zZ0L@fedora> (raw)
In-Reply-To: <20241217160720.2397239-2-vincent.guittot@linaro.org>
On Tue, Dec 17, 2024 at 05:07:14PM +0100, Vincent Guittot wrote:
> With EAS, a group should be set overloaded if at least 1 CPU in the group
> is overutilized bit it can happen that a CPU is fully utilized by tasks
typo - s/bit/but
> because of clamping the compute capacity of the CPU. In such case, the CPU
> is not overutilized and as a result should not be set overloaded as well.
>
> group_overloaded being a higher priority than group_misfit, such group can
> be selected as the busiest group instead of a group with a mistfit task
> and prevents load_balance to select the CPU with the misfit task to pull
> the latter on a fitting CPU.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Tested-by: Pierre Gondois <pierre.gondois@arm.com>
next prev parent reply other threads:[~2024-12-17 19:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 16:07 [PATCH 0/7 v2] sched/fair: Rework EAS to handle more cases Vincent Guittot
2024-12-17 16:07 ` [PATCH 1/7 v2] sched/fair: Filter false overloaded_group case for EAS Vincent Guittot
2024-12-17 19:15 ` Dhaval Giani [this message]
2024-12-17 16:07 ` [PATCH 2/7 v2] energy model: Add a get previous state function Vincent Guittot
2024-12-17 16:07 ` [PATCH 3/7 v2] sched/fair: Rework feec() to use cost instead of spare capacity Vincent Guittot
2024-12-24 16:46 ` Luis Machado
2024-12-17 16:07 ` [PATCH 4/7 v2] energy model: Remove unused em_cpu_energy() Vincent Guittot
2024-12-18 14:59 ` Christian Loehle
2024-12-17 16:07 ` [PATCH 5/7 v2] sched/fair: Add push task callback for EAS Vincent Guittot
2025-01-16 17:34 ` Pierre Gondois
2025-01-20 15:50 ` Vincent Guittot
2024-12-17 16:07 ` [PATCH 6/7 v2] sched/fair: Add misfit case to " Vincent Guittot
2025-01-16 17:35 ` Pierre Gondois
2025-01-20 15:50 ` Vincent Guittot
2024-12-17 16:07 ` [PATCH 7/7 v2] sched/fair: Update overutilized detection Vincent Guittot
2025-01-17 10:27 ` Pierre Gondois
2025-01-20 15:50 ` Vincent Guittot
2024-12-18 14:06 ` [PATCH 0/7 v2] sched/fair: Rework EAS to handle more cases Christian Loehle
2024-12-19 16:22 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2HNuK_Zyfc2zZ0L@fedora \
--to=dhaval@gianis.ca \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=hongyan.xia2@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pierre.gondois@arm.com \
--cc=qperret@google.com \
--cc=qyousef@layalina.io \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.