Re: [PATCH] meson.build: Disallow libnfs v6 to fix the broken macOS build

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Dec 18, 2024 at 07:51:57AM +0100, Thomas Huth wrote:
> The macOS build in our CI is currently broken since homebrew
> updated libnfs to version 6 - and that version apparently comes
> with a big API breakage. Disallow that version for now to get the
> broken CI job working again. Once somebody had enough time to
> adapt our code in block/nfs.c, we can revert this change again.

NB This isn't limited to macOS. We've already been broken by
this in Fedora:

  https://lists.nongnu.org/archive/html/qemu-block/2024-12/msg00151.html

other distros will no doubt break too soon enough.

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> 
> diff --git a/meson.build b/meson.build
> index 85f7485473..6149b50db2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1145,7 +1145,7 @@ endif
>  
>  libnfs = not_found
>  if not get_option('libnfs').auto() or have_block
> -  libnfs = dependency('libnfs', version: '>=1.9.3',
> +  libnfs = dependency('libnfs', version: ['>=1.9.3', '<6.0.0'],
>                        required: get_option('libnfs'),
>                        method: 'pkg-config')
>  endif
> -- 
> 2.47.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|