From: Ido Schimmel <idosch@idosch.org>
To: Radu Rendec <rrendec@redhat.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>,
Roopa Prabhu <roopa@nvidia.com>,
bridge@lists.linux.dev, netdev@vger.kernel.org,
Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 1/2] net: vxlan: rename SKB_DROP_REASON_VXLAN_NO_REMOTE
Date: Wed, 18 Dec 2024 18:50:20 +0200 [thread overview]
Message-ID: <Z2L9TFL0dWJn_D-M@shredder> (raw)
In-Reply-To: <20241217230711.192781-2-rrendec@redhat.com>
On Tue, Dec 17, 2024 at 06:07:10PM -0500, Radu Rendec wrote:
> @@ -497,8 +497,8 @@ enum skb_drop_reason {
> * entry or an entry pointing to a nexthop.
> */
> SKB_DROP_REASON_VXLAN_ENTRY_EXISTS,
> - /** @SKB_DROP_REASON_VXLAN_NO_REMOTE: no remote found for xmit */
> - SKB_DROP_REASON_VXLAN_NO_REMOTE,
> + /** @SKB_DROP_REASON_NO_TX_TARGET: no remote found for xmit */
Looks good, but I suggest replacing "remote" with "target" since
"remote" is VXLAN specific.
> + SKB_DROP_REASON_NO_TX_TARGET,
> /**
> * @SKB_DROP_REASON_IP_TUNNEL_ECN: skb is dropped according to
> * RFC 6040 4.2, see __INET_ECN_decapsulate() for detail.
> --
> 2.47.1
>
next prev parent reply other threads:[~2024-12-18 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 23:07 [PATCH net-next v2 0/2] net/bridge: Add skb drop reasons to the most common drop points Radu Rendec
2024-12-17 23:07 ` [PATCH net-next v2 1/2] net: vxlan: rename SKB_DROP_REASON_VXLAN_NO_REMOTE Radu Rendec
2024-12-18 16:50 ` Ido Schimmel [this message]
2024-12-17 23:07 ` [PATCH net-next v2 2/2] net: bridge: add skb drop reasons to the most common drop points Radu Rendec
2024-12-18 17:19 ` Ido Schimmel
2024-12-18 21:55 ` Radu Rendec
2024-12-18 22:50 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2L9TFL0dWJn_D-M@shredder \
--to=idosch@idosch.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=rrendec@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.