From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Kyle Lippincott <spectral@google.com>
Subject: Re: make GIT_VERSION=foo broken, was Re: [PATCH v2] doc: remove extra quotes in generated docs
Date: Wed, 18 Dec 2024 14:19:48 +0100 [thread overview]
Message-ID: <Z2LL9F8WANokZJ7R@pks.im> (raw)
In-Reply-To: <20241218113324.GA594795@coredump.intra.peff.net>
On Wed, Dec 18, 2024 at 06:33:24AM -0500, Jeff King wrote:
> Perhaps the script should be doing the same for GIT_VERSION itself,
> along with GIT_DATE?
I won't be able to have a look today or tomorrow, but will have a look
on Friday and send a patch, unless somebody else beats me to it.
Thanks for the report!
Patrick
next prev parent reply other threads:[~2024-12-18 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 23:47 [PATCH] doc: remove extra quotes in generated docs Kyle Lippincott via GitGitGadget
2024-12-18 0:53 ` Junio C Hamano
2024-12-18 0:57 ` [PATCH v2] " Kyle Lippincott via GitGitGadget
2024-12-18 1:11 ` Junio C Hamano
2024-12-18 1:22 ` Junio C Hamano
2024-12-18 11:33 ` make GIT_VERSION=foo broken, was " Jeff King
2024-12-18 13:19 ` Patrick Steinhardt [this message]
2024-12-18 12:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2LL9F8WANokZJ7R@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.