From: Vincent Donnefort <vdonnefort@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Edward Adam Davis <eadavis@qq.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
syzbot+345e4443a21200874b18@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com,
Jeongjun Park <aha310510@gmail.com>,
david@redhat.com
Subject: Re: [PATCH] ring-buffer: Fix a oob in __rb_map_vma
Date: Wed, 18 Dec 2024 14:31:31 +0000 [thread overview]
Message-ID: <Z2Lcw0StqsHgU7E6@google.com> (raw)
In-Reply-To: <20241218081958.55204fb3@gandalf.local.home>
On Wed, Dec 18, 2024 at 08:19:58AM -0500, Steven Rostedt wrote:
> On Wed, 18 Dec 2024 09:13:43 +0000
> Vincent Donnefort <vdonnefort@google.com> wrote:
>
> > And probably also
> >
> > Fixes: 117c39200d9d ("ring-buffer: Introducing ring-buffer mapping functions")
>
> I don't require patch submitters to add Fixes tags. It's more the
> responsibility of the maintainer to do that. I still have to validate it as
> there's been several times someone adds a Fixes tag which wasn't the right
> commit that it fixed.
>
> -- Steve
Ack.
Aside, there's a selftest to check for the overflow of subbufs with the
mapping... but of course it didn't test with offset > nr_subbufs.
Do you think it is worth to extend it to cover this case? I'm happy to do a
quick patch.
--
Vincent
next prev parent reply other threads:[~2024-12-18 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 8:23 [syzbot] [trace?] KASAN: use-after-free Read in ring_buffer_map syzbot
2024-12-16 13:42 ` Edward Adam Davis
2024-12-16 13:43 ` syzbot
2024-12-16 13:44 ` Edward Adam Davis
2024-12-16 14:06 ` syzbot
2024-12-16 14:07 ` [PATCH] ring-buffer: Fix a oob in __rb_map_vma Edward Adam Davis
2024-12-17 17:46 ` Steven Rostedt
2024-12-17 23:43 ` Edward Adam Davis
2024-12-18 0:40 ` Steven Rostedt
2024-12-18 1:23 ` Jeongjun Park
2024-12-18 9:13 ` Vincent Donnefort
2024-12-18 11:42 ` [PATCH V2] ring-buffer: fix overflow " Edward Adam Davis
2024-12-18 13:18 ` Steven Rostedt
2024-12-18 13:36 ` [PATCH V3] " Edward Adam Davis
2024-12-18 13:24 ` [PATCH V2] " Steven Rostedt
2024-12-18 13:19 ` [PATCH] ring-buffer: Fix a oob " Steven Rostedt
2024-12-18 14:31 ` Vincent Donnefort [this message]
2024-12-18 14:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2Lcw0StqsHgU7E6@google.com \
--to=vdonnefort@google.com \
--cc=aha310510@gmail.com \
--cc=david@redhat.com \
--cc=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=syzbot+345e4443a21200874b18@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.