Re: [RFC/RFT PATCH v2] hwmon: (lm75) Hide register size differences in regmap access functions

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Hi Guenter,

quick response, will test your new patch later.

> ---
> v2: Fix accesses to 16-bit configuration register.

Great, thanks, I missed that more fixing is needed.

>     Use regmap access functions for all operations on config register.
>     Declare regmap bus and use devm_regmap_init().

The regmap_bus solution is really nice! Didn't know about it.

>     Drop local configuration register copy; let regmap handle bit updates.

And one patch is gone from my queue. I had this as well :)

>     Note: The driver could use additional cleanup, such as using bit macros
>     and using devm_regulator_get_enable(). That is left for another day.

I didn't do BIT yet (although tempted), but I have the regulator cleanup
already. Also, 'client' can go from the priv struct with just a little
bit of reordering. I hope I can send all the stuff tomorrow.

I have the proof-of-concept running on I3C already, need to remove some
FIXMEs, though.

Thanks and happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]