From: Peter Xu <peterx@redhat.com>
To: Yuan Liu <yuan1.liu@intel.com>
Cc: farosas@suse.de, qemu-devel@nongnu.org, jason.zeng@intel.com,
yichen.wang@bytedance.com
Subject: Re: [PATCH 3/3] multifd: bugfix for incorrect migration data with qatzip compression
Date: Wed, 18 Dec 2024 12:08:54 -0500 [thread overview]
Message-ID: <Z2MBpsa8lWC4U5x-@x1n> (raw)
In-Reply-To: <20241218091413.140396-4-yuan1.liu@intel.com>
On Wed, Dec 18, 2024 at 05:14:13PM +0800, Yuan Liu wrote:
> When QPL compression is enabled on the migration channel and the same
> dirty page changes from a normal page to a zero page in the iterative
> memory copy, the dirty page will not be updated to a zero page again
> on the target side, resulting in incorrect memory data on the source
> and target sides.
>
> The root cause is that the target side does not record the normal pages
> to the receivedmap.
>
> The solution is to add ramblock_recv_bitmap_set_offset in target side
> to record the normal pages.
>
> Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
> Reviewed-by: Jason Zeng <jason.zeng@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2024-12-18 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 9:14 [PATCH 0/3] bugfixes for migration using compression methods Yuan Liu
2024-12-18 9:14 ` [PATCH 1/3] multifd: bugfix " Yuan Liu
2024-12-18 17:03 ` Peter Xu
2024-12-19 8:42 ` Liu, Yuan1
2024-12-18 9:14 ` [PATCH 2/3] multifd: bugfix for incorrect migration data with QPL compression Yuan Liu
2024-12-18 17:08 ` Peter Xu
2024-12-18 9:14 ` [PATCH 3/3] multifd: bugfix for incorrect migration data with qatzip compression Yuan Liu
2024-12-18 17:08 ` Peter Xu [this message]
2024-12-18 17:12 ` [PATCH 0/3] bugfixes for migration using compression methods Peter Xu
2025-01-12 13:12 ` Michael Tokarev
2025-01-13 0:58 ` Liu, Yuan1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2MBpsa8lWC4U5x-@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=jason.zeng@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=yichen.wang@bytedance.com \
--cc=yuan1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.