From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lmEw7-0004JB-7D for mharc-qemu-trivial@gnu.org; Thu, 27 May 2021 08:16:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmEw5-0004GM-SQ; Thu, 27 May 2021 08:16:25 -0400 Received: from mta-07-4.privateemail.com ([68.65.122.27]:7667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmEw2-0007Gz-DI; Thu, 27 May 2021 08:16:25 -0400 Received: from MTA-07.privateemail.com (localhost [127.0.0.1]) by MTA-07.privateemail.com (Postfix) with ESMTP id 8AD4360052; Thu, 27 May 2021 08:16:18 -0400 (EDT) Received: from [192.168.0.46] (unknown [10.20.151.229]) by MTA-07.privateemail.com (Postfix) with ESMTPA id A49AC6004E; Thu, 27 May 2021 08:16:17 -0400 (EDT) Date: Thu, 27 May 2021 08:16:11 -0400 From: Hamza Mahfooz Subject: Re: [PATCH] linux-user: make process_pending_signals thread-safe To: Peter Maydell Cc: Laurent Vivier , QEMU Trivial , QEMU Developers Message-Id: In-Reply-To: References: <20210524024655.11115-1-someguy@effective-light.com> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=68.65.122.27; envelope-from=someguy@effective-light.com; helo=MTA-07-4.privateemail.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 12:16:26 -0000 On Thu, May 27 2021 at 11:45:26 AM +0100, Peter Maydell wrote: > What issue are we trying to fix by making this change ? I suppose that it wouldn't fix any issues in the current state of affairs, maybe it is something to reconsider if glibc ever changes such that, sigprocmask is no longer MT-safe (which is within reason since the MT behavior of sigprocmask is undefined by POSIX). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F06FC47089 for ; Thu, 27 May 2021 12:23:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BC71613C0 for ; Thu, 27 May 2021 12:23:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BC71613C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=effective-light.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmF31-0007Pq-Jc for qemu-devel@archiver.kernel.org; Thu, 27 May 2021 08:23:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmEw5-0004GM-SQ; Thu, 27 May 2021 08:16:25 -0400 Received: from mta-07-4.privateemail.com ([68.65.122.27]:7667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmEw2-0007Gz-DI; Thu, 27 May 2021 08:16:25 -0400 Received: from MTA-07.privateemail.com (localhost [127.0.0.1]) by MTA-07.privateemail.com (Postfix) with ESMTP id 8AD4360052; Thu, 27 May 2021 08:16:18 -0400 (EDT) Received: from [192.168.0.46] (unknown [10.20.151.229]) by MTA-07.privateemail.com (Postfix) with ESMTPA id A49AC6004E; Thu, 27 May 2021 08:16:17 -0400 (EDT) Date: Thu, 27 May 2021 08:16:11 -0400 From: Hamza Mahfooz Subject: Re: [PATCH] linux-user: make process_pending_signals thread-safe To: Peter Maydell Message-Id: In-Reply-To: References: <20210524024655.11115-1-someguy@effective-light.com> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=68.65.122.27; envelope-from=someguy@effective-light.com; helo=MTA-07-4.privateemail.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Laurent Vivier , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 27 2021 at 11:45:26 AM +0100, Peter Maydell wrote: > What issue are we trying to fix by making this change ? I suppose that it wouldn't fix any issues in the current state of affairs, maybe it is something to reconsider if glibc ever changes such that, sigprocmask is no longer MT-safe (which is within reason since the MT behavior of sigprocmask is undefined by POSIX).