From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B169C1547FE; Wed, 18 Dec 2024 18:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734547295; cv=none; b=YcptEybVpCOoHKw+hb+lsh3OgXtK5JST/llLQ/k6LfKVTH26zYuhSPXKZg24wIrzqwRdkuSZU2l8g38p8M4c55DEjhEdqIjEHeg/Y+HkxvBWcAlFqeQVq/tVucm0WJf4BcvLqjT0Q8RissR3rYDvwO+wJEq+h1/lXm0gwe46Dd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734547295; c=relaxed/simple; bh=1Pk+Poo09suXrcvpVp1oeGmHxV7JSee/hgW3Otg+GAs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=of1cLxemnEEOiiOQd9hKFeA2ZG+thQASR3sas1c0mP4XYxj/efCEgvSKoxiBWy/VQe2LEnUSwFPtuS1TYygGLJZnSsRl3c3Pyd8Vu1n6EvdjcF1RGLDC6eLd8BgC5E8aBwGTZpwfjPTqx/ooEAn30ewrJ47ttkSfelNOHasf30M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uy330i6b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uy330i6b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9084FC4CECD; Wed, 18 Dec 2024 18:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734547295; bh=1Pk+Poo09suXrcvpVp1oeGmHxV7JSee/hgW3Otg+GAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uy330i6btvqwZgD3agJyLdpKiwp+PX1tQV0zDq654AyMEhBdyQm/UEzu8RrjK4RLB 7yT8BbG7fFfUcVyRZ6KSRe8bBpM/uPoVL/JNstJi/clCMSjO/C23S4q9Q0pwWfoMZa /uM2ofy+8XL3Xf6Ytbedoi3zgGU0YyRIlY37c/AI1JeJwXdTRvwkss2UkqjETmbexE T+kv6sITMUtX0NeLDbFdKv0cH5uY43wx/jXrgd+z4V57L+/AHPiROUog9JbuOcWfjb av1xFUrtzpAt7r4YmRzkhTEiC2FLWU2lOn/zYQporOQJUHJpA2dCL1zA91sM+YFWYh QT3q8QjhL1CLQ== Date: Wed, 18 Dec 2024 15:41:32 -0300 From: Arnaldo Carvalho de Melo To: Charlie Jenkins Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] tools: perf: tests: Fix code reading for riscv Message-ID: References: <20241217-perf_fix_riscv_obj_reading-v2-1-58f81b7b4c7d@rivosinc.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Dec 17, 2024 at 04:30:15PM -0800, Charlie Jenkins wrote: > On Tue, Dec 17, 2024 at 04:18:32PM -0800, Ian Rogers wrote: > > On Tue, Dec 17, 2024 at 3:52 PM Charlie Jenkins wrote: > > > After binutils commit e43d876 which was first included in binutils 2.41, > > > riscv no longer supports dumping in the middle of instructions. Increase > > > the objdump window by 2-bytes to ensure that any instruction that sits > > > on the boundary of the specified stop-address is not cut in half. > > > Signed-off-by: Charlie Jenkins > > Reviewed-by: Ian Rogers > > > A binutils patch has been sent as well to fix this in objdump [1]. > > > Link: https://sourceware.org/pipermail/binutils/2024-December/138139.html [1] > > > Changes in v2: > > > - Do objdump version detection at runtime (Ian) > > > - Link to v1: https://lore.kernel.org/r/20241216-perf_fix_riscv_obj_reading-v1-0-b75962660a9b@rivosinc.com > > > --- a/tools/perf/tests/code-reading.c > > > @@ -183,9 +244,30 @@ static int read_via_objdump(const char *filename, u64 addr, void *buf, > > > const char *fmt; > > > FILE *f; > > > int ret; > > > + u64 stop_address = addr + len; > > > + > > > + if (IS_ENABLED(__riscv)) { > > Not sure if there is a consistency issue here. Elsewhere we're just > > using ifdef, such as: > > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/include/dwarf-regs.h?h=perf-tools-next#n69 > I don't have any strong feelings about that. I can change it to be an > ifdef. On other lists I have been told to use IS_ENABLED whenever > possible, but it's only a small difference. Can't we just use uname here? So that we don't use kconfig.h since its not used in tools/perf/ and makes it looks like perf is in lockstep with the kernel source tree version it was compiled from? $ git grep kconfig.h tools/perf/ $ BTW, what would happen if I collected a perf.data file on x86_64 and would read it in a RiscV machine with such a objdump version? The same problem? - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE81DE77187 for ; Wed, 18 Dec 2024 18:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4kc8vyi+JRLRC4UnArQYhzx98PTbbAzcI70IyHQj4sk=; b=TZMPKkmaV+BHgD 2v937Qt+5Iu7nbfXCu/b8Zyp9prywG/W45ekiq6XL2RFYs0/Srlpu61obcMU9IVrKuCt59ChpsPsx nsr036ocd+RQQlLZwtnbyJiB4lN3q3V4ArXJRhv15rEJq30Jk0JLxcPR5Bm1WKpyRxOVqURrjJZYC 7klPrsGHBLEw8Y2280g3gfFKL3gMpiajVF9ZVbA9JnBndDiyWFr6vXXXqTsUs+XoSBah4ZPQXKaY7 bU7TVPUI1M8WRSRtcwCRzHi+XE3gIc5Co13XcRzsCiGo9ArssLlBTPuIkLc+pfX7c0BwUSgOkt6cm 0cRA+qScKdSZPAro1qHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNyzL-0000000HTJl-0gah; Wed, 18 Dec 2024 18:41:39 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tNyzI-0000000HTIs-24Gk for linux-riscv@lists.infradead.org; Wed, 18 Dec 2024 18:41:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DED6CA40191; Wed, 18 Dec 2024 18:39:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9084FC4CECD; Wed, 18 Dec 2024 18:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734547295; bh=1Pk+Poo09suXrcvpVp1oeGmHxV7JSee/hgW3Otg+GAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uy330i6btvqwZgD3agJyLdpKiwp+PX1tQV0zDq654AyMEhBdyQm/UEzu8RrjK4RLB 7yT8BbG7fFfUcVyRZ6KSRe8bBpM/uPoVL/JNstJi/clCMSjO/C23S4q9Q0pwWfoMZa /uM2ofy+8XL3Xf6Ytbedoi3zgGU0YyRIlY37c/AI1JeJwXdTRvwkss2UkqjETmbexE T+kv6sITMUtX0NeLDbFdKv0cH5uY43wx/jXrgd+z4V57L+/AHPiROUog9JbuOcWfjb av1xFUrtzpAt7r4YmRzkhTEiC2FLWU2lOn/zYQporOQJUHJpA2dCL1zA91sM+YFWYh QT3q8QjhL1CLQ== Date: Wed, 18 Dec 2024 15:41:32 -0300 From: Arnaldo Carvalho de Melo To: Charlie Jenkins Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] tools: perf: tests: Fix code reading for riscv Message-ID: References: <20241217-perf_fix_riscv_obj_reading-v2-1-58f81b7b4c7d@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241218_104136_656912_2ED20712 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBEZWMgMTcsIDIwMjQgYXQgMDQ6MzA6MTVQTSAtMDgwMCwgQ2hhcmxpZSBKZW5raW5z IHdyb3RlOgo+IE9uIFR1ZSwgRGVjIDE3LCAyMDI0IGF0IDA0OjE4OjMyUE0gLTA4MDAsIElhbiBS b2dlcnMgd3JvdGU6Cj4gPiBPbiBUdWUsIERlYyAxNywgMjAyNCBhdCAzOjUy4oCvUE0gQ2hhcmxp ZSBKZW5raW5zIDxjaGFybGllQHJpdm9zaW5jLmNvbT4gd3JvdGU6Cj4gPiA+IEFmdGVyIGJpbnV0 aWxzIGNvbW1pdCBlNDNkODc2IHdoaWNoIHdhcyBmaXJzdCBpbmNsdWRlZCBpbiBiaW51dGlscyAy LjQxLAo+ID4gPiByaXNjdiBubyBsb25nZXIgc3VwcG9ydHMgZHVtcGluZyBpbiB0aGUgbWlkZGxl IG9mIGluc3RydWN0aW9ucy4gSW5jcmVhc2UKPiA+ID4gdGhlIG9iamR1bXAgd2luZG93IGJ5IDIt Ynl0ZXMgdG8gZW5zdXJlIHRoYXQgYW55IGluc3RydWN0aW9uIHRoYXQgc2l0cwo+ID4gPiBvbiB0 aGUgYm91bmRhcnkgb2YgdGhlIHNwZWNpZmllZCBzdG9wLWFkZHJlc3MgaXMgbm90IGN1dCBpbiBo YWxmLgoKPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hhcmxpZSBKZW5raW5zIDxjaGFybGllQHJpdm9z aW5jLmNvbT4KCj4gPiBSZXZpZXdlZC1ieTogSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29nbGUuY29t PgoKPiA+ID4gQSBiaW51dGlscyBwYXRjaCBoYXMgYmVlbiBzZW50IGFzIHdlbGwgdG8gZml4IHRo aXMgaW4gb2JqZHVtcCBbMV0uCgo+ID4gPiBMaW5rOiBodHRwczovL3NvdXJjZXdhcmUub3JnL3Bp cGVybWFpbC9iaW51dGlscy8yMDI0LURlY2VtYmVyLzEzODEzOS5odG1sIFsxXQoKPiA+ID4gQ2hh bmdlcyBpbiB2MjoKPiA+ID4gLSBEbyBvYmpkdW1wIHZlcnNpb24gZGV0ZWN0aW9uIGF0IHJ1bnRp bWUgKElhbikKPiA+ID4gLSBMaW5rIHRvIHYxOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIw MjQxMjE2LXBlcmZfZml4X3Jpc2N2X29ial9yZWFkaW5nLXYxLTAtYjc1OTYyNjYwYTliQHJpdm9z aW5jLmNvbQoKPiA+ID4gLS0tIGEvdG9vbHMvcGVyZi90ZXN0cy9jb2RlLXJlYWRpbmcuYwo+ID4g PiBAQCAtMTgzLDkgKzI0NCwzMCBAQCBzdGF0aWMgaW50IHJlYWRfdmlhX29iamR1bXAoY29uc3Qg Y2hhciAqZmlsZW5hbWUsIHU2NCBhZGRyLCB2b2lkICpidWYsCj4gPiA+ICAgICAgICAgY29uc3Qg Y2hhciAqZm10Owo+ID4gPiAgICAgICAgIEZJTEUgKmY7Cj4gPiA+ICAgICAgICAgaW50IHJldDsK PiA+ID4gKyAgICAgICB1NjQgc3RvcF9hZGRyZXNzID0gYWRkciArIGxlbjsKPiA+ID4gKwo+ID4g PiArICAgICAgIGlmIChJU19FTkFCTEVEKF9fcmlzY3YpKSB7Cgo+ID4gTm90IHN1cmUgaWYgdGhl cmUgaXMgYSBjb25zaXN0ZW5jeSBpc3N1ZSBoZXJlLiBFbHNld2hlcmUgd2UncmUganVzdAo+ID4g dXNpbmcgaWZkZWYsIHN1Y2ggYXM6Cj4gPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20v bGludXgva2VybmVsL2dpdC9wZXJmL3BlcmYtdG9vbHMtbmV4dC5naXQvdHJlZS90b29scy9wZXJm L3V0aWwvaW5jbHVkZS9kd2FyZi1yZWdzLmg/aD1wZXJmLXRvb2xzLW5leHQjbjY5CiAKPiBJIGRv bid0IGhhdmUgYW55IHN0cm9uZyBmZWVsaW5ncyBhYm91dCB0aGF0LiBJIGNhbiBjaGFuZ2UgaXQg dG8gYmUgYW4KPiBpZmRlZi4gT24gb3RoZXIgbGlzdHMgSSBoYXZlIGJlZW4gdG9sZCB0byB1c2Ug SVNfRU5BQkxFRCB3aGVuZXZlcgo+IHBvc3NpYmxlLCBidXQgaXQncyBvbmx5IGEgc21hbGwgZGlm ZmVyZW5jZS4KCkNhbid0IHdlIGp1c3QgdXNlIHVuYW1lIGhlcmU/CgpTbyB0aGF0IHdlIGRvbid0 IHVzZSBrY29uZmlnLmggc2luY2UgaXRzIG5vdCB1c2VkIGluIHRvb2xzL3BlcmYvIGFuZAptYWtl cyBpdCBsb29rcyBsaWtlIHBlcmYgaXMgaW4gbG9ja3N0ZXAgd2l0aCB0aGUga2VybmVsIHNvdXJj ZSB0cmVlCnZlcnNpb24gaXQgd2FzIGNvbXBpbGVkIGZyb20/CgokIGdpdCBncmVwIGtjb25maWcu aCB0b29scy9wZXJmLwokCgpCVFcsIHdoYXQgd291bGQgaGFwcGVuIGlmIEkgY29sbGVjdGVkIGEg cGVyZi5kYXRhIGZpbGUgb24geDg2XzY0IGFuZAp3b3VsZCByZWFkIGl0IGluIGEgUmlzY1YgbWFj aGluZSB3aXRoIHN1Y2ggYSBvYmpkdW1wIHZlcnNpb24/IFRoZSBzYW1lCnByb2JsZW0/CgotIEFy bmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK