All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	James Clark <james.clark@linaro.org>,
	Howard Chu <howardchu95@gmail.com>,
	Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
	Michael Petlan <mpetlan@redhat.com>,
	Veronika Molnarova <vmolnaro@redhat.com>,
	Dapeng Mi <dapeng1.mi@linux.intel.com>,
	Thomas Richter <tmricht@linux.ibm.com>,
	Ilya Leoshkevich <iii@linux.ibm.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	Weilin Wang <weilin.wang@intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v7 00/22] Python module cleanup
Date: Wed, 18 Dec 2024 16:27:51 -0300	[thread overview]
Message-ID: <Z2MiNxw5a4HXwhFQ@x1> (raw)
In-Reply-To: <20241119011644.971342-1-irogers@google.com>

On Mon, Nov 18, 2024 at 05:16:22PM -0800, Ian Rogers wrote:
> This patch:
>  - removes workarounds for Python 2 module support due to long
>    deprecation and challenges in developing new code;
>  - constifies variables and parameters to functions;
>  - removes python.c stub code which existed due to missing functions
>    that are defined in the builtin-* files, in general the builtin-*
>    code is moved into util;
>  - remove bench and test perf C code from the python module;
>  - adds parse_events to the python perf module.
>  - improves upon some of the existing python perf module functins.
> 
> v7. Move ifdef-ed function stubs into header file for Namhyung.
> v6. Rebase. When moving find_scripts, separate the switch to using
>     is_directory_at into a patch before moving the function,
>     Arnaldo/Namhyung. Add acked/tested tags from Arnaldo and Adrian.
> v5. Rebase. Fix NO_LIBBPF and NO_AUXTRACE related build failures
>     caught by Arnaldo and the build-test. Fix NO_AUXTRACE x86
>     arch_fetch_insn in the process, which was incorrectly using an
>     empty weak symbol stub.
> v4. Rebase. Fix the parse events evsel to be embedded in a
>     pyrf_evsel. Add __str__/__repr__ functions to evlist and
>     evsel. Throw an exception for a bad evlist index.
> v3. Move is_directory_at to patch 6 rather than patch 7, respond to
>     review feedback on the list from Namhyung.
> v2. Add the bottom 4 bullet points - 13 more patches.

Thanks, applied, testing.

- Arnaldo

      parent reply	other threads:[~2024-12-18 19:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19  1:16 [PATCH v7 00/22] Python module cleanup Ian Rogers
2024-11-19  1:16 ` [PATCH v7 01/22] perf python: Remove python 2 scripting support Ian Rogers
2024-11-19  1:16 ` [PATCH v7 02/22] perf python: Constify variables and parameters Ian Rogers
2024-11-19  1:16 ` [PATCH v7 03/22] perf python: Remove unused #include Ian Rogers
2024-11-19  1:16 ` [PATCH v7 04/22] perf script: Move scripting_max_stack out of builtin Ian Rogers
2024-11-19  1:16 ` [PATCH v7 05/22] perf kvm: Move functions used in util " Ian Rogers
2024-11-19  1:16 ` [PATCH v7 06/22] perf script: Use openat for directory iteration Ian Rogers
2024-11-19  1:16 ` [PATCH v7 07/22] perf script: Move find_scripts to browser/scripts.c Ian Rogers
2024-11-19  1:16 ` [PATCH v7 08/22] perf stat: Move stat_config into config.c Ian Rogers
2024-11-19  1:16 ` [PATCH v7 09/22] perf script: Move script_spec code to trace-event-scripting.c Ian Rogers
2024-11-19  1:16 ` [PATCH v7 10/22] perf script: Move script_fetch_insn " Ian Rogers
2024-11-19  1:16 ` [PATCH v7 11/22] perf script: Move perf_sample__sprintf_flags " Ian Rogers
2024-11-19  1:16 ` [PATCH v7 12/22] perf x86: Define arch_fetch_insn in NO_AUXTRACE builds Ian Rogers
2024-11-19  1:16 ` [PATCH v7 13/22] perf intel-pt: Remove stale build comment Ian Rogers
2024-11-19  1:16 ` [PATCH v7 14/22] perf env: Move arch errno function to only use in env Ian Rogers
2024-11-19  1:16 ` [PATCH v7 15/22] perf lock: Move common lock contention code to new file Ian Rogers
2024-11-19 19:05   ` Namhyung Kim
2024-11-19  1:16 ` [PATCH v7 16/22] perf bench: Remove reference to cmd_inject Ian Rogers
2024-11-19  1:16 ` [PATCH v7 17/22] perf kwork: Make perf_kwork_add_work a callback Ian Rogers
2024-11-19  1:16 ` [PATCH v7 18/22] perf build: Remove test library from python shared object Ian Rogers
2024-11-19  1:16 ` [PATCH v7 19/22] perf python: Add parse_events function Ian Rogers
2024-11-19  1:16 ` [PATCH v7 20/22] perf python: Add __str__ and __repr__ functions to evlist Ian Rogers
2024-11-19  1:16 ` [PATCH v7 21/22] perf python: Add __str__ and __repr__ functions to evsel Ian Rogers
2024-11-19  1:16 ` [PATCH v7 22/22] perf python: Correctly throw IndexError Ian Rogers
2024-12-18 19:27 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z2MiNxw5a4HXwhFQ@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=colin.i.king@gmail.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=howardchu95@gmail.com \
    --cc=iii@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    --cc=vmolnaro@redhat.com \
    --cc=weilin.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.